Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Jul 8, 2016

Fixes #1412

To Dos

  • Docs
  • Tests
    • System
    • Unit

Example

var id = gcloud.datastore.int('100000000000001234');
var key = datastore.key(['Kind', id]);

// everything from this point should work normally.

@stephenplusplus stephenplusplus added the api: datastore Issues related to the Datastore API. label Jul 8, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2016
@stephenplusplus
Copy link
Contributor Author

@callmehiphop wdyt?

@callmehiphop
Copy link
Contributor

LGTM

@callmehiphop
Copy link
Contributor

Kind of side note/after thought. But datastore is cool with accepting strings? Might be worth mentioning that Bigtable will bring in a new dependency for supporting Int64 values. Not sure if datastore will accept those as an ID, but the library we're using will convert a string into an Int64.

@stephenplusplus
Copy link
Contributor Author

Good thinking, it might make more sense to use that here, then. I'll wait for the Bigtable merge and play with it.

@stephenplusplus stephenplusplus merged commit bab982f into googleapis:master Mar 10, 2017
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
**Description:**

There is an incompatibility with the current protobufjs version and it is blocking the CI pipeline. https://togithub.com/googleapis/nodejs-datastore/actions/runs/17623790707/job/50075476485?pr=1405 for more details

**Impact:**

Unblocks the CI pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants