Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore namespace fix #1212

Merged
merged 3 commits into from
Apr 7, 2016
Merged

Datastore namespace fix #1212

merged 3 commits into from
Apr 7, 2016

Conversation

idoshamun
Copy link
Contributor

When using allocateId the namespace option was ignored due to a typo

idoshamun added 2 commits April 7, 2016 10:10
@idoshamun
datastore: fix namespace isolation
0a9dd79 
when using allocateId the namespace option was ignored due to typo
@idoshamun
add ido shamun to contributors
93162f5
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2016
@stephenplusplus
Copy link
Contributor

Thank you! Could you also fix the tests? https://travis-ci.org/GoogleCloudPlatform/gcloud-node/jobs/121357907#L3059

@idoshamun
Copy link
Contributor Author

👍

@stephenplusplus stephenplusplus merged commit fc111c1 into googleapis:master Apr 7, 2016
@stephenplusplus
Copy link
Contributor

Thanks!

@snyk-bot snyk-bot mentioned this pull request Jan 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idoshamun @stephenplusplus @googlebot