Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute: support Forwarding Rules #1191

Merged
merged 1 commit into from
Apr 18, 2016
Merged

compute: support Forwarding Rules #1191

merged 1 commit into from
Apr 18, 2016

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Mar 29, 2016 •
edited
Loading

For #1073

This adds support for forwarding rules (regional and global).

To Dos

  • Docs
  • Tests
    • System
    • Unit
      • index.js
      • region.js
      • rule.js

@stephenplusplus stephenplusplus added enhancement api: compute Issues related to the Compute Engine API. labels Mar 29, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2016
@callmehiphop callmehiphop mentioned this pull request Mar 29, 2016
Closed
20 tasks
@stephenplusplus stephenplusplus force-pushed the spp--1073-forwarding-rules branch 2 times, most recently from 4a5dd15 to 87f6f0b Compare April 15, 2016 18:37
@coveralls
Copy link

Coverage Status

Coverage decreased (-76.9%) to 23.116% when pulling 87f6f0b on stephenplusplus:spp--1073-forwarding-rules into 5199cad on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus force-pushed the spp--1073-forwarding-rules branch 2 times, most recently from 35e613f to ae4de07 Compare April 15, 2016 18:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-75.06%) to 24.935% when pulling 35e613f on stephenplusplus:spp--1073-forwarding-rules into 5199cad on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus force-pushed the spp--1073-forwarding-rules branch 2 times, most recently from 7608316 to 11e2797 Compare April 18, 2016 16:48
@stephenplusplus
Copy link
Contributor Author

@callmehiphop ptal! I had some issues with the docs tests not having rule defined. That's just a heads-up for when Travis finishes, he'll likely be complaining about the same thing... could you see if I missed anything obvious that would fix that?

callmehiphop
callmehiphop reviewed Apr 18, 2016
View reviewed changes
lib/compute/rule.js
*
* @param {module:compute|module:compute/region} scope - The parent scope this
* firewall rule belongs to.
* @param {string} name - Rule name.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop
callmehiphop reviewed Apr 18, 2016
View reviewed changes
system-test/compute.js
@@ -24,7 +24,7 @@ var is = require('is');
var env = require('./env.js');
var Compute = require('../lib/compute/index.js');

describe('Compute', function() {
describe.only('Compute', function() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a42326b on stephenplusplus:spp--1073-forwarding-rules into 5199cad on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus mentioned this pull request Apr 18, 2016
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ca6965d on stephenplusplus:spp--1073-forwarding-rules into 24fbcdc on GoogleCloudPlatform:master.

@callmehiphop callmehiphop merged commit c6d6bc3 into googleapis:master Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenplusplus @coveralls @callmehiphop @googlebot