Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus added docs api: bigquery Issues related to the BigQuery API. labels Jan 18, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2016
callmehiphop added a commit that referenced this pull request Jan 18, 2016
@callmehiphop callmehiphop merged commit 44d27f4 into master Jan 18, 2016
@stephenplusplus stephenplusplus deleted the spp--bigquery-example branch February 2, 2016 13:38
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/gax-nodejs/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
* fix: Allows nulls to be passed into value

A user expressed interest in filtering with a null value. This typescript parameter change will now allow users to do so.

fixes #958

* Add tests in the system test folder

The code in the system test folder reflects the user experience more closely so we want to provide test cases there that will break when compiling typescript if new changes in src are not provided.

* Assert statements in system tests

Add assert statements to check that the value in the filter created in the system test actually equals null.

* Modify tests to assert check for null

Slight rename in system tests. Modified tests so that they test to see that the filter has a null value.

* Prefer elvis operator in assert statements

This change replaces the a longer fragment with elvis operator to make assert statements more concise.

* eliminate the need for a variable

In two tests we eliminate variables and just have an assert statement so that we can have more concise code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants