Skip to content

Transaction Documentation #623

Closed
@stephenplusplus

Description

Related: #621

Should we privatize transaction#begin and transaction#commit, removing them from the public docs and their usage in other Transaction examples?

A user goes through their Dataset instance to get a Transaction:

dataset.runInTransaction(transaction, done) {});

This calls transaction.begin immediately, and the done function returned to their callback is actually transaction.commit.

Having these methods appear in the docs is probably quite confusing, as the user shouldn't need (or be able to) begin a transaction that already began, or commit the transaction before calling done (commit) again.

Metadata

Labels

api: datastoreIssues related to the Datastore API.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions