datastore: allow storing empty objects (#1454)

googleapis · Jul 27, 2016 · c741869 · c741869
1 parent 9cdcef5
commit c741869
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/lib/datastore/entity.js b/lib/datastore/entity.js
@@ -283,10 +283,12 @@ function encodeValue(value) {
     return valueProto;
   }
 
-  if (is.object(value) && !is.empty(value)) {
-    for (var prop in value) {
-      if (value.hasOwnProperty(prop)) {
-        value[prop] = entity.encodeValue(value[prop]);
+  if (is.object(value)) {
+    if (!is.empty(value)) {
+      for (var prop in value) {
+        if (value.hasOwnProperty(prop)) {
+          value[prop] = entity.encodeValue(value[prop]);
+        }
       }
     }
 

diff --git a/test/datastore/entity.js b/test/datastore/entity.js
@@ -430,9 +430,21 @@ describe('entity', function() {
       assert.deepEqual(entity.encodeValue(value), expectedValueProto);
     });
 
+    it('should encode an empty object', function() {
+      var value = {};
+
+      var expectedValueProto = {
+        entityValue: {
+          properties: {}
+        }
+      };
+
+      assert.deepEqual(entity.encodeValue(value), expectedValueProto);
+    });
+
     it('should throw if an invalid value was provided', function() {
       assert.throws(function() {
-        entity.encodeValue({});
+        entity.encodeValue();
       }, /Unsupported field value/);
     });
   });