Skip to content

Commit

Permalink
testing: add blacklist for ci system testing (#1698)
Browse files Browse the repository at this point in the history
  • Loading branch information
callmehiphop authored and stephenplusplus committed Oct 17, 2016
1 parent 4374e6f commit 67a8a81
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ var Module = helpers.Module;

// Get a list of the modules that have code changes.
var modules = Module.getUpdated();
var skipSystem = ['common'];

if (!modules.length && !ci.isReleaseBuild()) {
echo('No code changes found, exiting early.');
Expand All @@ -68,8 +69,14 @@ modules.forEach(function(mod) {
mod.runSnippetTests();
});

// not every module (common) has system tests, so we'll filter those
// out for the next phase.
modules = modules.filter(function(mod) {
return skipSystem.indexOf(mod.name) > -1;
});

// If this is a push to master, let's run system tests
if (ci.isPushToMaster()) {
if (ci.isPushToMaster() && modules.length) {
// Run system tests for each module
// If they pass then create a symlink via npm link
modules.forEach(function(mod) {
Expand Down Expand Up @@ -102,5 +109,8 @@ if (ci.isReleaseBuild()) {

mod.install();
mod.runUnitTests();
mod.runSystemTests();

if (skipSystem.indexOf(mod.name) > -1) {
mod.runSystemTests();
}
}

0 comments on commit 67a8a81

Please sign in to comment.