Skip to content

Commit

Permalink
chore: address lint and docs issues (#7)
Browse files Browse the repository at this point in the history
  • Loading branch information
JustinBeckwith authored Jun 27, 2021
1 parent c6e406f commit 5d64cdd
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 14 deletions.
1 change: 0 additions & 1 deletion packages/google-cloud-lifesciences/.repo-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@
"default_version": "v2beta",
"requires_billing": true
}

Empty file.
11 changes: 10 additions & 1 deletion packages/google-cloud-lifesciences/linkinator.config.json
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
{"recurse":true,"skip":["https://codecov.io/gh/googleapis/","www.googleapis.com","img.shields.io"],"silent":true,"concurrency":10}
{
"recurse": true,
"skip": [
"https://codecov.io/gh/googleapis/",
"www.googleapis.com",
"img.shields.io"
],
"silent": true,
"concurrency": 10
}
11 changes: 6 additions & 5 deletions packages/google-cloud-lifesciences/samples/quickstart.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
'use strict';

async function main() {

// [START nodejs_life_sciences_quickstart]
// Imports the Google Cloud client library

Expand All @@ -31,10 +30,12 @@ async function main() {

//TODO(library generator): write the actual function you will be testing
async function doSomething() {
console.log('DPE! Change this code so that it shows how to use the library! See comments below on structure.')
// const [thing] = await client.methodName({
// });
// console.info(thing);
console.log(
'DPE! Change this code so that it shows how to use the library! See comments below on structure.'
);
// const [thing] = await client.methodName({
// });
// console.info(thing);
}
doSomething();
// [END nodejs_life_sciences_quickstart]
Expand Down
11 changes: 4 additions & 7 deletions packages/google-cloud-lifesciences/samples/test/quickstart.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const cwd = path.join(__dirname, '..');
const client = new {WorkflowsServiceV2BetaClient}();

describe('Quickstart', () => {
//TODO: remove this if not using the projectId
//TODO: remove this if not using the projectId
// eslint-disable-next-line no-unused-vars
let projectId;

Expand All @@ -42,12 +42,9 @@ describe('Quickstart', () => {
});

it('should run quickstart', async () => {
//TODO: remove this line
// eslint-disable-next-line no-unused-vars
const stdout = execSync(
`node ./quickstart.js`,
{cwd}
);
//TODO: remove this line
// eslint-disable-next-line no-unused-vars
const stdout = execSync('node ./quickstart.js', {cwd});
//assert(stdout, stdout !== null);
});
});

0 comments on commit 5d64cdd

Please sign in to comment.