fix: import run_asset_discovery_response.proto (#119)

packages/google-cloud-securitycenter/protos/google/cloud/securitycenter/v1/securitycenter_service.proto

@@ -21,6 +21,7 @@ import "google/api/annotations.proto";
 import "google/cloud/securitycenter/v1/asset.proto";
 import "google/cloud/securitycenter/v1/finding.proto";
 import "google/cloud/securitycenter/v1/organization_settings.proto";
+import "google/cloud/securitycenter/v1/run_asset_discovery_response.proto";
 import "google/cloud/securitycenter/v1/security_marks.proto";
 import "google/cloud/securitycenter/v1/source.proto";
 import "google/iam/v1/iam_policy.proto";

packages/google-cloud-securitycenter/samples/.eslintrc.yml

@@ -2,3 +2,4 @@
 rules:
   no-console: off
   node/no-missing-require: off
+  no-warning-comments: off

packages/google-cloud-securitycenter/src/index.js

@@ -15,6 +15,10 @@
 /**
  * @namespace google
  */
+/**
+ * @namespace google.type
+ */
+
 /**
  * @namespace google.cloud
  */

packages/google-cloud-securitycenter/src/v1/doc/google/iam/v1/doc_iam_policy.js

@@ -45,6 +45,12 @@ const SetIamPolicyRequest = {
  *   REQUIRED: The resource for which the policy is being requested.
  *   See the operation documentation for the appropriate value for this field.
  *
+ * @property {Object} options
+ *   OPTIONAL: A `GetPolicyOptions` object for specifying options to
+ *   `GetIamPolicy`. This field is only used by Cloud IAM.
+ *
+ *   This object should have the same structure as [GetPolicyOptions]{@link google.iam.v1.GetPolicyOptions}
+ *
  * @typedef GetIamPolicyRequest
  * @memberof google.iam.v1
  * @see [google.iam.v1.GetIamPolicyRequest definition in proto format]{@link https://github.com/googleapis/googleapis/blob/master/google/iam/v1/iam_policy.proto}

packages/google-cloud-securitycenter/src/v1/doc/google/iam/v1/doc_options.js

@@ -0,0 +1,33 @@
+// Copyright 2019 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Note: this file is purely for documentation. Any contents are not expected
+// to be loaded as the JS file.
+
+/**
+ * Encapsulates settings provided to GetIamPolicy.
+ *
+ * @property {number} requestedPolicyVersion
+ *   Optional. The policy format version to be returned.
+ *   Acceptable values are 0 and 1.
+ *   If the value is 0, or the field is omitted, policy format version 1 will be
+ *   returned.
+ *
+ * @typedef GetPolicyOptions
+ * @memberof google.iam.v1
+ * @see [google.iam.v1.GetPolicyOptions definition in proto format]{@link https://github.com/googleapis/googleapis/blob/master/google/iam/v1/options.proto}
+ */
+const GetPolicyOptions = {
+  // This is for documentation. Actual contents will be loaded by gRPC.
+};

packages/google-cloud-securitycenter/src/v1/security_center_client.js

@@ -440,6 +440,11 @@ class SecurityCenterClient {
    * @param {string} request.resource
    *   REQUIRED: The resource for which the policy is being requested.
    *   See the operation documentation for the appropriate value for this field.
+   * @param {Object} [request.options]
+   *   OPTIONAL: A `GetPolicyOptions` object for specifying options to
+   *   `GetIamPolicy`. This field is only used by Cloud IAM.
+   *
+   *   This object should have the same structure as [GetPolicyOptions]{@link google.iam.v1.GetPolicyOptions}
    * @param {Object} [options]
    *   Optional parameters. You can override the default settings for this call, e.g, timeout,
    *   retries, paginations, etc. See [gax.CallOptions]{@link https://googleapis.github.io/gax-nodejs/interfaces/CallOptions.html} for the details.

packages/google-cloud-securitycenter/src/v1beta1/doc/google/iam/v1/doc_iam_policy.js

@@ -45,6 +45,12 @@ const SetIamPolicyRequest = {
  *   REQUIRED: The resource for which the policy is being requested.
  *   See the operation documentation for the appropriate value for this field.
  *
+ * @property {Object} options
+ *   OPTIONAL: A `GetPolicyOptions` object for specifying options to
+ *   `GetIamPolicy`. This field is only used by Cloud IAM.
+ *
+ *   This object should have the same structure as [GetPolicyOptions]{@link google.iam.v1.GetPolicyOptions}
+ *
  * @typedef GetIamPolicyRequest
  * @memberof google.iam.v1
  * @see [google.iam.v1.GetIamPolicyRequest definition in proto format]{@link https://github.com/googleapis/googleapis/blob/master/google/iam/v1/iam_policy.proto}

packages/google-cloud-securitycenter/src/v1beta1/doc/google/iam/v1/doc_options.js

@@ -0,0 +1,33 @@
+// Copyright 2019 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Note: this file is purely for documentation. Any contents are not expected
+// to be loaded as the JS file.
+
+/**
+ * Encapsulates settings provided to GetIamPolicy.
+ *
+ * @property {number} requestedPolicyVersion
+ *   Optional. The policy format version to be returned.
+ *   Acceptable values are 0 and 1.
+ *   If the value is 0, or the field is omitted, policy format version 1 will be
+ *   returned.
+ *
+ * @typedef GetPolicyOptions
+ * @memberof google.iam.v1
+ * @see [google.iam.v1.GetPolicyOptions definition in proto format]{@link https://github.com/googleapis/googleapis/blob/master/google/iam/v1/options.proto}
+ */
+const GetPolicyOptions = {
+  // This is for documentation. Actual contents will be loaded by gRPC.
+};

packages/google-cloud-securitycenter/src/v1beta1/security_center_client.js

@@ -431,6 +431,11 @@ class SecurityCenterClient {
    * @param {string} request.resource
    *   REQUIRED: The resource for which the policy is being requested.
    *   See the operation documentation for the appropriate value for this field.
+   * @param {Object} [request.options]
+   *   OPTIONAL: A `GetPolicyOptions` object for specifying options to
+   *   `GetIamPolicy`. This field is only used by Cloud IAM.
+   *
+   *   This object should have the same structure as [GetPolicyOptions]{@link google.iam.v1.GetPolicyOptions}
    * @param {Object} [options]
    *   Optional parameters. You can override the default settings for this call, e.g, timeout,
    *   retries, paginations, etc. See [gax.CallOptions]{@link https://googleapis.github.io/gax-nodejs/interfaces/CallOptions.html} for the details.

packages/google-cloud-securitycenter/synth.metadata

@@ -1,19 +1,19 @@
 {
-  "updateTime": "2019-06-18T01:04:11.762881Z",
+  "updateTime": "2019-07-02T21:50:39.781012Z",
   "sources": [
     {
       "generator": {
         "name": "artman",
-        "version": "0.26.0",
-        "dockerImage": "googleapis/artman@sha256:6db0735b0d3beec5b887153a2a7c7411fc7bb53f73f6f389a822096bd14a3a15"
+        "version": "0.29.3",
+        "dockerImage": "googleapis/artman@sha256:8900f94a81adaab0238965aa8a7b3648791f4f3a95ee65adc6a56cfcc3753101"
       }
     },
     {
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "384aa843867c4d17756d14a01f047b6368494d32",
-        "internalRef": "253675319"
+        "sha": "69916b6ffbb7717fa009033351777d0c9909fb79",
+        "internalRef": "256241904"
       }
     },
     {

packages/google-cloud-securitycenter/synth.py

@@ -35,6 +35,20 @@
         r"\[\\p\{L\}\\p\{N\}\]\(https:\/\/cloud\.google\.com\{\\p\{L\}\\p\{N\}_- \]\{0\,30\}\[\\p\{L\}\\p\{N\}\]\)\?",
         r"`\[\p{L}\p{N}]({\p{L}\p{N}_- ]{0,30}[\p{L}\p{N}])?`")
 
+# cleanup some hiccups in jsdoc comments.
+s.replace("src/index.js",
+r"""\/\*\*
+ \* @namespace google
+ \*/""",
+r"""
+/**
+ * @namespace google
+ */
+/**
+ * @namespace google.type
+ */
+""")
+
 # [START fix-dead-link]
 s.replace('**/doc/google/protobuf/doc_timestamp.js',
         'https:\/\/cloud\.google\.com[\s\*]*http:\/\/(.*)[\s\*]*\)',