Skip to content

Commit

Permalink
fix: drop unused files from package (#137)
Browse files Browse the repository at this point in the history
  • Loading branch information
JustinBeckwith authored Apr 13, 2020
1 parent 24c6c52 commit 1971f26
Show file tree
Hide file tree
Showing 10 changed files with 20 additions and 67 deletions.
3 changes: 2 additions & 1 deletion packages/google-cloud-phishingprotection/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
**/node_modules
src/**/doc/*
**/coverage
test/fixtures
build/
docs/
protos/
9 changes: 6 additions & 3 deletions packages/google-cloud-phishingprotection/.prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
node_modules/*
samples/node_modules/*
src/**/doc/*
**/node_modules
**/coverage
test/fixtures
build/
docs/
protos/
5 changes: 1 addition & 4 deletions packages/google-cloud-phishingprotection/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
"main": "build/src/index.js",
"files": [
"build/protos",
"build/src",
"AUTHORS",
"COPYING"
"build/src"
],
"keywords": [
"google apis client",
Expand Down Expand Up @@ -41,7 +39,6 @@
"mocha": "^7.0.0",
"null-loader": "^3.0.0",
"pack-n-play": "^1.0.0-2",
"prettier": "^1.17.0",
"sinon": "^9.0.1",
"ts-loader": "^6.2.1",
"typescript": "^3.8.3",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
---
rules:
no-console: off
node/no-missing-require: off
node/no-extraneous-require: off
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "Apache-2.0",
"author": "Google LLC",
"engines": {
"node": ">=8"
"node": ">=10"
},
"files": [
"*.js"
Expand Down

This file was deleted.

12 changes: 7 additions & 5 deletions packages/google-cloud-phishingprotection/synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,25 @@
{
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-phishing-protection.git",
"sha": "f530cee08819d7e5faea57f1df2a514e23552067"
"remote": "git@github.com:googleapis/nodejs-phishing-protection.git",
"sha": "2a29c86fdfda267937fdb0ea559344a376c4cde9"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "1bd77e8ce6f953ac641af7966d0c52646afc16a8",
"internalRef": "305974465"
"sha": "26523a96798ce1a6caa1b3c912119059cfcc98a7",
"internalRef": "306320014",
"log": "26523a96798ce1a6caa1b3c912119059cfcc98a7\nchore: delete gapic config for resourcemanager/v2\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306320014\n\n35672e7936b923eff048d0ee1529faa163cc81b8\nchore: enable gapicv2 for datacatalog/v1beta1 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306318928\n\ndea1f52034d188ca371c3a70c716ca2a6b3f2aa1\nchore: delete gapic config for language/v1beta1\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306298030\n\ndf955af5d9508cf9215de6f1fbdad033d5b8fef6\nchore: enable gapicv2 for language/v1beta2 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306297639\n\ne2a59ff2f861b1b92b2f15b242780dccddd77ab9\nchore: enable gapicv2 for bigquery/reservation/v1 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306297615\n\nc9942c00e8f35b5b37cd589ef7a0323aeda264e2\nchore: enable gapicv2 for datacatalog/v1beta1 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306297587\n\nf561f57eea013327be27d8f6799b3cc2d18ee804\nbazel: upgrade gapic-generator-go to v0.13.2\n\nChanges include:\n* update Bazel rules_go to v0.22.3\n* update Bazel Go repositories with latest\n* fix Bazel go_gapic_assembly_pkg archive contents path\n\nPiperOrigin-RevId: 306294636\n\na34f4eb96a94bfd5b3e7f8de253db28d0a3e9237\nchore: enable gapicv2 for asset/v1beta1 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306283252\n\n4efd71279f0781579ced60c374336ce1b8b8cea8\nchore: enable gapicv2 for asset/v1p4beta1 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306282838\n\n789fd7e0680b04a589447139811d55c5d1f34afe\nchore: enable gapicv2 for asset/v1p1beta1 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306282062\n\n0feb08065d91d6deebffef3019751f0619a72140\nchore: enable gapicv2 for asset/v1p2beta1 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306281797\n\n9ea892ebe8a7cd66da9bd62eb7086b8dc2ddd559\nchore: enable gapicv2 for vision/v1 API\n\nCommitter: @miraleung\nPiperOrigin-RevId: 306281271\n\n4d61e1cb40184a7ad63ef37b1813f6608718674a\nAdd speech adaptation, phrase sets and custom classes.\n\nPiperOrigin-RevId: 306280989\n\n3824f547aa44df459580615c73cabb30a2a78ee0\nfeat: Adding Retry policy for OS Config V1Beta AgentEndpointService\n\nPiperOrigin-RevId: 306254195\n\n"
}
},
{
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "6f32150677c9784f3c3a7e1949472bd29c9d72c5"
"sha": "3df869dd6eb546ef13beeb7a9efa6ee0226afafd",
"log": "3df869dd6eb546ef13beeb7a9efa6ee0226afafd\nci: add dependency list completeness check (#490)\n\n\n682c0c37d1054966ca662a44259e96cc7aea4413\nbuild(nodejs): update lint ignore rules (#488)\n\n\n97c7ccfdceb927db1cbe6f3bb09616aa02bafd89\ndoc: document context-aware commit flags (#481)\n\nAlso, delete obsolete blurb about cleaning up old, dead files.\n\nCo-authored-by: Jeff Ching <chingor@google.com>\n8eff3790f88b50706a0c4b6a20b385f24e9ac4e7\nfeat: common postprocessing for node libraries (#485)\n\nCo-authored-by: Justin Beckwith <justin.beckwith@gmail.com>\n21c3b57ae54ae9db6a3a6b48b31c970c6ab56f19\nbuild(nodejs): remove unused codecov config (#486)\n\n\n"
}
}
],
Expand Down
3 changes: 1 addition & 2 deletions packages/google-cloud-phishingprotection/synth.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

AUTOSYNTH_MULTIPLE_COMMITS = True


# run the gapic generator
gapic = gcp.GAPICMicrogenerator()
versions = ['v1beta1']
Expand All @@ -45,5 +44,5 @@

# Node.js specific cleanup
subprocess.run(['npm', 'install'])
subprocess.run(['npm', 'run', 'lint'])
subprocess.run(['npm', 'run', 'fix'])
subprocess.run(['npx', 'compileProtos', 'src'])
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {readFileSync} from 'fs';
import {describe, it} from 'mocha';

describe('typescript consumer tests', () => {
it('should have correct type signature for typescript users', async function() {
it('should have correct type signature for typescript users', async function () {
this.timeout(300000);
const options = {
packageDir: process.cwd(), // path to your module.
Expand All @@ -35,7 +35,7 @@ describe('typescript consumer tests', () => {
await packNTest(options); // will throw upon error.
});

it('should have correct type signature for javascript users', async function() {
it('should have correct type signature for javascript users', async function () {
this.timeout(300000);
const options = {
packageDir: process.cwd(), // path to your module.
Expand Down
3 changes: 0 additions & 3 deletions packages/google-cloud-phishingprotection/tslint.json

This file was deleted.

0 comments on commit 1971f26

Please sign in to comment.