Merged
Conversation
RE: googleapis/google-cloud-node#996 (comment) Previously, we were forwarding events from a request stream to a cache stream. When the request is confirmed "good to go", the cache stream is piped to the user's stream. The thought was the events would be forwarded, too. It kind of worked, but had some edge cases. `streamForward` has always been tricky. It turns out it's not all that helpful, but more confusing in practice. It's now removed from use in this library. Instead, we are now forwarding events manually.
remove stream-cache
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsdoc-fresh](https://togithub.com/googleapis/jsdoc-fresh) | [`^2.0.0` -> `^3.0.0`](https://renovatebot.com/diffs/npm/jsdoc-fresh/2.0.2/3.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/jsdoc-fresh (jsdoc-fresh)</summary> ### [`v3.0.0`](https://togithub.com/googleapis/jsdoc-fresh/blob/HEAD/CHANGELOG.md#300-2023-08-10) [Compare Source](https://togithub.com/googleapis/jsdoc-fresh/compare/v2.0.2...v3.0.0) ##### ⚠ BREAKING CHANGES - upgrade to Node 14 ##### Miscellaneous Chores - Upgrade to Node 14 ([50c1a03](https://togithub.com/googleapis/jsdoc-fresh/commit/50c1a0328a2ff7b1940989b6818366535f1c47a2)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/retry-request). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
* fix: Add `system-test/fixtures` to `.eslintignore` * refactor: Use `**` Source-Link: googleapis/synthtool@b7858ba Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:abc68a9bbf4fa808b25fa16d3b11141059dc757dbc34f024744bba36c200b40f Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat!: Remove `request` fallback, Update docs/types, * fix: undocumented `string` URL param support * feat: Export `defaults` * fix: test timeout * chore(deps): update `mocha` * test: use `teeny-request` as replacement default * fix: handle stream complete/finish events uniformly on errors `teeny-request` and `request` emit different calls when an error occurs. * chore: update timeout for (slow) `windows` instance
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* fix: types Used `npm link` to verify in another library. * fix: docs + `getNextRetryDelay`'s signature
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <fenster@google.com>
* chore: add deprecation notice to library
* chore: update links in github issue templates * chore: update links in github issue templates Source-Link: googleapis/synthtool@38fa49f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:609822e3c09b7a1bd90b99655904609f162cc15acb4704f1edf778284c36f429 * Update owlbot.py * Delete .github/ISSUE_TEMPLATE/bug_report.md * Update bug_report.yml * Delete .github/ISSUE_TEMPLATE/feature_request.md * Update feature_request.yml * Delete .github/ISSUE_TEMPLATE/question.md * Delete .github/scripts/close-invalid-link.cjs * Delete .github/workflows/issues-no-repro.yaml * Update .repo-metadata.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
* chore!: upgrade to Node 18 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update .OwlBot.lock.yaml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * run lint * add TS configuration file for linting * Delete .github/workflows/issues-no-repro.yaml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update package.json * retry test * extend timeout * extend timeout to fix flaky test --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: resolve vulnerability * Update package.json * Update package.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Delete .kokoro/presubmit/node14 directory * Update readme.md * Update readme.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
miguelvelezsa
approved these changes
Dec 5, 2025
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕