feat: add packages in conditional tests#74
Merged
miguelvelezsa merged 2 commits intomainfrom Oct 6, 2025
Merged
Conversation
miguelvelezsa
changed the title
sofisl
approved these changes
Oct 6, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Oct 10, 2025
Large numbers returned by the metadata service were being handled incorrectly. They would get parsed as JSON by `axios` which loses precision when converting to JS numbers. It seems that as far as RFC 4627 is concerned, large numbers are valid JSON. The spec doesn't specify any precision for numbers. This means that using JSON.parse is unsafe unless the API guarantees that it will return large numbers as strings (or otherwise JSON.parseable data type). Instead, use `json-bigint` to parse JSON. This would have no change to the current behavior if the numbers are representable as JavaScript numbers. For larger numbers, it returns a BigNumber.
Closed
This was referenced Oct 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.