Skip to content

lint: replace require with import in test #659

@xiaozhenliu-gg5

Description

@xiaozhenliu-gg5

remove /* eslint-disable @typescript-eslint/no-var-requires */ in test.

It needs more changes than just making _innerApiCalls public. LROperation, gax.CallOptions ... are incompatible with the real types of method calls. Some of them can be forced compatible but lots of as unknown as someType will be used. As @alexander-fenster suggested, we should move unit test to sinon for removing custom mock codes.

ref: googleapis/gapic-generator-typescript#343

Metadata

Metadata

Labels

p3type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions