-
Notifications
You must be signed in to change notification settings - Fork 11
Closed
googleapis/gapic-generator-typescript
#1066Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.
Description
Based on the discussion here:
- return this.innerApiCalls.listen(options);
+ return this.innerApiCalls.listen({}, options);@schmidt-sebastian wrote:
I do think the generated code is busted here. We use options to set an additional header, but the way this gets passed down here is as the request (if I remember this correctly). If we don't modify the code, the header is dropped. This only affects bidirectional streaming APIs with additional metadata, so probably just us. I do think we should fix this upstream at some point.
We need to figure out what's wrong there, and fix it in the generator.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.