Stack traces don't tell me where the call originated

[JustinBeckwith]

I have this code:

const {CloudBuildClient} = require('@google-cloud/cloudbuild').v1;
const util = require('util');

const build = new CloudBuildClient();

const paths = [
  'healthcare/datasets',
  'healthcare/dicom',
  'healthcare/fhir',
  'healthcare/hl7v2',
];

async function main() {
  const projectId = await build.getProjectId();
  const [triggers] = await build.listBuildTriggers({projectId});
  for (const trigger of triggers) {
    console.log(util.inspect(trigger, false, 6));
  }

  for (const path of paths) {
    const name = `nodejs-docs-samples-${path.replace('/', '-')}`;
    const exists = triggers.find(x => x.name === name);
    const triggerRequest = {
      projectId,
      trigger: {
        name,
        serviceAccount:
          'kokoro-system-test@long-door-651.iam.gserviceaccount.com',
        includedFiles: [`${path}/**`],
        github: {
          installationId: '0',
          owner: 'GoogleCloudPlatform',
          name: 'nodejs-docs-samples',
          pullRequest: {
            commentControl: 'COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY',
            invertRegex: false,
            branch: '^main$',
            gitRef: 'branch',
          },
          event: 'pullRequest',
        },
        build: {
          steps: [
            {
              name: 'node:14',
              entrypoint: 'npm',
              args: ['install', '--unsafe-perm'],
              dir: path,
            },
            {
              name: 'node:14',
              entrypoint: 'npm',
              args: ['run', 'test'],
              dir: path,
            },
          ],
        },
      },
    };
    if (exists) {
      console.log(`updating trigger ${name}...`);
      await build.updateBuildTrigger(triggerRequest);
    } else {
      console.log(`creating trigger ${name}...`);
      await build.createBuildTrigger(triggerRequest);
    }
  }
}

main().catch(e => {
  console.error(e);
  throw e;
});

And I'm getting a stack trace like this:

(node:90035) UnhandledPromiseRejectionWarning: Error: 3 INVALID_ARGUMENT: Request contains an invalid argument.
    at Object.callErrorFromStatus (/Users/beckwith/Code/nodejs-docs-samples/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (/Users/beckwith/Code/nodejs-docs-samples/node_modules/@grpc/grpc-js/build/src/client.js:179:52)
    at Object.onReceiveStatus (/Users/beckwith/Code/nodejs-docs-samples/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:336:141)
    at Object.onReceiveStatus (/Users/beckwith/Code/nodejs-docs-samples/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:299:181)
    at /Users/beckwith/Code/nodejs-docs-samples/node_modules/@grpc/grpc-js/build/src/call-stream.js:145:78
    at processTicksAndRejections (internal/process/task_queues.js:77:11)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:90035) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:90035) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Nothing in that stack trace points to the actual line of code where the request as made. This makes it super hard to know which call actually caused the exception.

[summer-ji-eng]

Currently gax-nodejs can only understand and decode the 'grpc-status-details-bin' in Metadata object.
However, the error got from the service has only grpc-server-stats-bin which gax-nodejs is not able to decode as well. An API service need to provide error_details, so that gax-nodejs can decode as human-readable message.

I dig into the call response, I got this value, and as you could see in this code grpc-js read fromHttp2Headers, and append this key-value into the error metadata. Not sure what the value is.

[summer-ji-eng]

A good example API implement https://google.aip.dev/193, provide error details

And GAPIC client library is able to parse the error and provide clear and more information for debug like

Help {
  links: [
    Link {
      description: 'Google developers console API activation',
      url: 'https://console.developers.google.com/apis/api/translate.googleapis.com/overview?project=xxxxxxxxxxxx'
    }
  ]
}
ErrorInfo {
  metadata: {
    service: 'translate.googleapis.com',
    consumer: 'xxxxxxxxxxxx'
  },
  reason: 'SERVICE_DISABLED',
  domain: 'googleapis.com'
}

[summer-ji-eng]

Close the issue, feel free to open if you have any question. Thanks