Skip to content

Remove deprecated and optional field for generated samples #588

@sofisl

Description

@sofisl

See https://github.com/googleapis/nodejs-dlp/pull/656/files

  /**
   * TODO(developer): Uncomment these variables before running the sample.
   */
  /**
   *  Required. Parent resource name.
   *  The format of this value varies depending on whether you have [specified a
   *  processing
   *  location](https://cloud.google.com/dlp/docs/specifying-location):
   *  + Projects scope, location specified:<br/>
   *    `projects/`<var>PROJECT_ID</var>`/locations/`<var>LOCATION_ID</var>
   *  + Projects scope, no location specified (defaults to global):<br/>
   *    `projects/`<var>PROJECT_ID</var>
   *  The following example `parent` string specifies a parent project with the
   *  identifier `example-project`, and specifies the `europe-west3` location
   *  for processing data:
   *      parent=projects/example-project/locations/europe-west3
   */
  // const parent = 'abc123'
  /**
   *  Set to control what and how to inspect.
   */
  // const inspectJob = ''
  /**
   *  Set to choose what metric to calculate.
   */
  // const riskJob = ''
  /**
   *  The job id can contain uppercase and lowercase letters,
   *  numbers, and hyphens; that is, it must match the regular
   *  expression: `[a-zA-Z\d-_]+`. The maximum length is 100
   *  characters. Can be empty to allow the system to generate one.
   */
  // const jobId = 'abc123'
  /**
   *  Deprecated. This field has no effect.
   */
  // const locationId = 'abc123'

and

// [START cloudasset_v1_generated_AssetService_AnalyzeIamPolicy_async]
  /**
   * TODO(developer): Uncomment these variables before running the sample.
   */
  /**
   *  Required. The request query.
   */
  // const analysisQuery = ''
  /**
   *  Optional. Amount of time executable has to complete.  See JSON representation of
   *  [Duration](https://developers.google.com/protocol-buffers/docs/proto3#json).
   *  If this field is set with a value less than the RPC deadline, and the
   *  execution of your query hasn't finished in the specified
   *  execution timeout,  you will get a response with partial result.
   *  Otherwise, your query's execution will continue until the RPC deadline.
   *  If it's not finished until then, you will get a  DEADLINE_EXCEEDED error.
   *  Default is empty.
   */
  // const executionTimeout = ''

googleapis/nodejs-asset#562

Metadata

Metadata

Assignees

Labels

priority: p3Desirable enhancement or fix. May not be included in next release.samplesIssues that are directly related to samples.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions