timeout field isn't being considered while fetching the Bearer token

[sreendra]

Environment details

• OS: Linux
• Node.js version: 10
• npm version: 6
• google-auth-library version:5.10.1

Steps to reproduce

1. ? Set timeout to 3secs
2. ? Make a million calls in an hour

You would see that the response time will be greater than 15secs or more at least for few requests as timeout is being considered only validating the recaptcha token not during fetching the Bearer token.

We are using JWT to validate reCaptcha token and it's taking more than 15sec to get the response for few requests inspite of the timeout being set to 3 ms.

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

[JustinBeckwith]

Greetings! Can you share the code you're using here? Ideally, you wouldn't need to request a new access token on every request. This can happen if you're instantiating a new client library service object or a new GoogleAuth object for every request.

Can you share what you're trying?

[sreendra]

Hi @JustinBeckwith ,

As you mentioned, we are also not creating a client instance for every call. It's only 1 call per instance. please find the code below.

const   asyncRetryUtil =  require('async-retry'),
        {auth} = require('google-auth-library'),
        https = require('https');

const agent = new https.Agent({keepAlive: true});

let parsedSvcAcctKey;
let client = null;

class GRCEnterprise {
    getSvcAcctKey(req){
        if(!parsedSvcAcctKey){
            try{
                parsedSvcAcctKey = //JSON_SVC_ACCT;
            }catch(error) {
                throw new Error('Failed to fetch svc acct key');
            }
        }
        return parsedSvcAcctKey;
    }

    getRecaptchaClient(req){
        if(!client){
            let svcAcctKey = this.getSvcAcctKey(req);
            //Check grc enterprise svc acct is set, else throw error to caller to take action
            if(!svcAcctKey){
                throw new Error("GRC Enterprise SvcAcct is empty");
            }
            client = auth.fromJSON(svcAcctKey);
        }
        return client;
    }
}

    async verify(req, grcEntToken, publicKey) {

        const client = this.getRecaptchaClient(req);
        let responseDetails = null;        
        try {            
            client.scopes =['https://www.googleapis.com/auth/cloud-platform'];
            const timeout = 3000;
            const numOfRetries = 3;
            responseDetails = await asyncRetryUtil(async (bail, attempt) => {
                const response = await client.request( { 
                    url :  ent_url,
                    agent,
                    body : JSON.stringify( {
                        event:{
                            token:grcEntToken,
                            siteKey:publicKey
                        }}),
                    timeout:timeout,
                    retryConfig:{retry:1},
                    headers: {
                        'Content-Type': 'application/json' },
                    method : 'POST'
                });

                if(response.status === 200){
                    return response.data;
                }

                if(response.status === 403) {
                    bail(new Error('Unauthorized'));
                    return;
                }

                throw new Error('Retrying again');
            },{
                retries:numOfRetries,
                factor:1,
                minTimeout:100,
                onRetry: err => {
                    //Log
                },
            });            
        }catch(error) {
            //Log
        }        
        return responseDetails;
    }

Upon debugging the code, what intrigued us is, timeout parameter that we pass to the api call is not being used while fetching the Bearer token, because of which we are seeing that the response time of the call is at times crossing 16 secs even though we set a timeout of 3 secs.

I have posted this issue on behalf of Paypal and we make almost a 1M+ calls in an hour.

Since the outliers are taking 16secs or so right, they are actually distorting 99% response time.

I hope these details are suffice and please reach out to us if you feel something is vague.

Regards.

[JustinBeckwith]

Ok, I think understand what you're asking about now :) As it stands today, the GaxiosOptions you pass into the client.request method are not carried over to requests to obtain tokens, work with the metadata server, or anything else. The request options you're passing into that method are only used for the URI you are currently requesting.

None of the options for requests (with the exception of Proxy) are overridable, generally because the various APIs we use have very specific requirements.

I'm a little more concerned about your 16 second timeout. Where is this code running?

[sreendra]

Apologies @JustinBeckwith , i missed your message. The code is running on PayPal OnPrim machines.

Our request is, could you please set a timeout even for the call to fetch the Bearer token

Regards

[anilvpatel21]

Hi JustinBeckwith,

I am using google-api-nodejs-client,
Debian GNU/Linux
Node v10.13.0
googleapis: 52.1.0
google-auth-library: ^6.0.0,
googleapis-common: ^4.3.0

Sometimes fetching access token using refresh token when it expires, https://oauth2.googleapis.com/token , takes 2-4min to give response or eventually fails ETIMEDOUT. Do not know why it is failing, simple curl request is also taking time to response sometimes.

From the client side when we request, it goes to express on nodeJS to call googleapis. I am creating an events using calendarAPIs. Please help me out. googleapis/google-auth-library-nodejs#283 Issue, similar to my problem, does it resolve.

[pnowakaero]

I have same issue like anilvpatel21. Any solutions?

[sudheeshskrishna]

@JustinBeckwith Has this been addressed in any later versions?

[alexander-fenster]

Folks, to set a timeout for authentication, you can use the idea of "default settings" in gaxios, the library we use for making HTTP requests. Somewhere in the beginning of your code, do this:

const gaxios = require('gaxios');
gaxios.instance.defaults = {
  timeout: 3000, // milliseconds
};

Then all requests that don't have timeout set in the options (auth requests included) will have this default timeout.