Limits being called "exceeded" when being hit exactly

[AKPWebDesign]

I'm using the PubSub library, which is failing with the following error:

Unhandled rejection Error: The number of elements 1000 exceeds the limit 1000
    at BundleExecutor.schedule ([project_directory]\node_modules\google-gax\lib\bundling.js:354:14)
    at [project_directory]\node_modules\google-gax\lib\bundling.js:474:20
    at Canceller.call ([project_directory]\node_modules\google-gax\lib\api_callable.js:110:19)
    at Bundleable.call ([project_directory]\node_modules\google-gax\lib\bundling.js:473:12)
    at [project_directory]\node_modules\google-gax\lib\api_callable.js:356:17
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

It seems to me that either the word "exceeds" should be changed, or the checks at bundling.js:344 and bundling.js:347 should be changed from >= to >.

[funkswing]

google-gax v0.14.3

The checks are here:
https://github.com/googleapis/gax-nodejs/blob/master/lib/bundling.js#L356
https://github.com/googleapis/gax-nodejs/blob/master/lib/bundling.js#L360

I ran into this issue when using Google PubSub node client to send millions of messages as quickly as possible.

Changing the logic to > instead of >= in the two lines above removed theError: The number of elements 1000 exceeds the limit 1000 error message.

[antonomoon]

@jmuk what do you think?

[funkswing]

Just incase anybody sees this issue before a fix is merged, a working fix is to set a batching message limit for publisher:

const publisher = topic.publisher({
    batching: {
        maxMessages: 999
    }
});

[AdriVanHoudt]

Is there a eta on a fix?
I just ran in to this and @funkswing's fix works 👌

[vchudnov-g]

@alexander-fenster Any updates on this?

[wyardley]

I threw up a PR that implements @funkswing's changes + one change to accommodate this in the tests. Not quite sure why this hasn't been looked at since it was flagged as P2 (maybe there were some additional considerations that make this more complicated?) and assigned to someone in late May @JustinBeckwith.