Wrong path when resolving protofile (datastore)

[danielcardeenas]

Environment details

• OS: Windows 10
• Node.js version: 9.11.1
• npm version: 6.1.0
• @google-cloud/datastore version: 2.0.0

Steps to reproduce

1. Use @google/datastore library (runtime)

At runtime. When trying to use datastore library, next error occurs

UnhandledPromiseRejectionWarning: Error: google/datastore/v1/datastore.proto could not be found in \protos
    at Function.GrpcClient._resolveFile (C:\Users\eduardo.cardenas\projects\manufactalent_api\node_modules\google-gax\build\src\grpc.js:220:15)
    at GrpcClient.loadProto (C:\Users\eduardo.cardenas\projects\manufactalent_api\node_modules\google-gax\build\src\grpc.js:209:39)
    at new DatastoreClient (webpack:///./node_modules/@google-cloud/datastore/src/v1/datastore_client.js?:98:15)

Current code.
COMMON_PROTO_FILES array does not contains string "google/datastore/v1/datastore.proto". Also the contents of the array have strings like "google\type\date.proto" (Notice the backslash instead). Maybe an OS issue?

// grpc.js
GrpcClient._resolveFile = function (protoPath, filename) {
      if (fs.existsSync(path.join(protoPath, filename))) {
          return path.join(protoPath, filename);
      }
      else if (COMMON_PROTO_FILES.indexOf(filename) > -1) {
          return path.join(googleProtoFilesDir, filename);
      }
      throw new Error(filename + ' could not be found in ' + protoPath);
  };

Workaround: use googleProtoFilesDir like "google/datastore/v1/datastore.proto" was there in the array

// grpc.js
GrpcClient._resolveFile = function (protoPath, filename) {
      if (fs.existsSync(path.join(googleProtoFilesDir, filename))) {
          return path.join(googleProtoFilesDir, filename);
      }
      else if (COMMON_PROTO_FILES.indexOf(filename) > -1) {
          return path.join(googleProtoFilesDir, filename);
      }
      throw new Error(filename + ' could not be found in ' + protoPath);
  };

[danielcardeenas]

This bug happens in production build only

[JustinBeckwith]

Greetings! In @google-cloud/datastore 3.0, we started using a different approach to resolving paths for proto files. @danielcardeenas would you be willing to give this a shot with the latest version?

[danielcardeenas]

Of course

[JustinBeckwith]

Greetings! If this is still an issue, please do let us know. I'm like 99% sure we fixed the glitch, so I'm closing this out for now.

[danielcardeenas]

After updating now I'm facing the next issue:
Caught exception: TypeError: Datastore is not a constructor

[JustinBeckwith]

Can you create a new issue in googleapis/nodejs-datastore with details?

[danielcardeenas]

Of course googleapis/nodejs-datastore#340

[danielcardeenas]

After fixing the constructor issue:
UnhandledPromiseRejectionWarning: Error: google/datastore/v1/datastore.proto could not be found in \protos I got the same issue as before

Which I fixed using the same Workaround explained before

[FrozenKiwi]

Hi, I'm facing the same(?) issue (Electron5).

google-gax:1.1.1
webpack:////node_modules/google-gax/build/src/grpc.js@line45
const googleProtoFilesDir = path.join(__dirname, '..', '..', 'protos');
resolves to "/protos"

After a lot of searching I've traced the issue to Webpack:
https://stackoverflow.com/questions/43527016/dirname-is-not-working-in-node-js-with-webpack-bundling

This indicates the issue is not on google-gax side, but it's still probably the easiest place to resolve it.

[FrozenKiwi]

My actual error:

Uncaught (in promise) Error: error reading first path in the walk \protos
Error: ENOENT: no such file or directory, lstat '\protos'