Skip to content

Rawresponse not being sent to the promise callback when pagination is not used #422

@Shrek-DevMasterRobo

Description

@Shrek-DevMasterRobo

I am using Talent-solution module for creating, updating and deleting Jobs. Also, in the meanwhile I am sending the client events as well, for which the request_id is required of the previous calls. But, when the API is being called without any pagination, the raw response is being sent back to the callback. Need this response in order to capture the request id.

Line that needs change - https://github.com/googleapis/gax-nodejs/blob/master/src/paginationCalls/pagedApiCaller.ts#L145

Need it changed to the following
canceller.callback(null, allResources, null, response);

Metadata

Metadata

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions