-
Notifications
You must be signed in to change notification settings - Fork 11
Closed
googleapis/gax-nodejs
#1530Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Environment details
- OS: Linux
- Node.js version: 20.9.0
- npm version: 10.1.0
gax-nodejsversion: gapic-tools@0.2.0
Steps to reproduce
compileProtos esm/src --esm (generated by https://github.com/googleapis/gapic-generator-typescript when passing --format esm)
The generateRootName function tries to locate package.json one directory above the input path, but in this case it should hop through 2 parent directories. I wonder if it makes sense to just use package.json from the current directory, at least when the path is relative and doesn't start with ../.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.