chore: add test for new client generation #8670
Conversation
meltsufin
force-pushed
the
gh-action-newclient
branch
2 times, most recently
from
a8da0ea to
80d3706
Compare
meltsufin
force-pushed
the
gh-action-newclient
branch
from
f74563f to
d1d9dd2
Compare
meltsufin
changed the title
How about yoshi-code-bot account? https://github.com/googleapis/google-cloud-java/blob/main/.github/workflows/readme.yaml#L35 (I don't know its entitlement) |
Doesn't seem to be working either. |
meltsufin
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
meltsufin
force-pushed
the
gh-action-newclient
branch
from
123c243 to
40cd445
Compare
meltsufin
changed the title
.github/workflows/newclient.yaml
Outdated
| - name: Push to branch | ||
| run: | | ||
| [ -z "`git config user.email`" ] && git config --global user.email "${USERNAME:-script}@google.com" | ||
| [ -z "`git config user.name`" ] && git config --global user.name "${USERNAME:-script}" | ||
| git checkout -b newclient_output_${{ github.event_name }} | ||
| git add --all | ||
| git commit -m 'feat: re-generated apikeys' | ||
| git remote add monorepo https://${{ github.actor }}:${{ github.token }}@github.com/${{ github.repository }}.git | ||
| git fetch -q --unshallow monorepo | ||
| git push -f monorepo newclient_output_${{ github.event_name }} |
There was a problem hiding this comment.
How does "Push to branch" help verify the behavior of new-client.py?
There was a problem hiding this comment.
It's just there for debugging, in case the job fails.
|
How might we verify new-client.py’s logic of adding a corresponding new entry to gapic BOM, release please configuration files, and the root pom.xml? |
Fixes: #8659