Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable lint (fmt-maven-plugin and checkstyle) #8604

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Conversation

meltsufin
Copy link
Member

No description provided.

@suztomo
Copy link
Member

suztomo commented Oct 14, 2022

There must be some unnecessary command basename. The checkstyle Maven invocation succeeded.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  38.084 s
[INFO] Finished at: 2022-10-14T14:52:49Z
[INFO] ------------------------------------------------------------------------
basename: missing operand
Try 'basename --help' for more information.

@suztomo
Copy link
Member

suztomo commented Oct 14, 2022

@meltsufin
Copy link
Member Author

@suztomo Apparently build.sh in the current form doesn't work on GitHub actions, although it works in other repos.

@meltsufin meltsufin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2022
@suztomo suztomo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 14, 2022
@suztomo
Copy link
Member

suztomo commented Oct 14, 2022

Do not merge to main until the release goes through. (updating main branch resets the release pull request)

@suztomo suztomo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 18, 2022
@suztomo suztomo merged commit 58d5541 into main Oct 18, 2022
@suztomo suztomo deleted the enable-lint branch October 18, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants