Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: script to apply versions.txt to pom.xml #8542

Merged
merged 4 commits into from
Oct 7, 2022
Merged

chore: script to apply versions.txt to pom.xml #8542

merged 4 commits into from
Oct 7, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 6, 2022 •
edited
Loading

Fixes #8532 with generation/apply_current_versions.sh.

meltsufin
meltsufin approved these changes Oct 6, 2022
View reviewed changes
generation/apply_current_versions.sh
for KV in $(cut -f1,3 -d: $versions_file |grep -v "#"); do
K=${KV%:*}; V=${KV#*:}
echo Key:$K, Value:$V;
pom_files="$(find $MODULE -maxdepth 3 -name pom.xml) pom.xml CoverageAggregator/pom.xml google-cloud-gapic-bom/pom.xml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have to list CoverageAggregator and google-cloud-gapic-bom explicitly? Wouldn't those poms be found automatically?

Copy link
Member Author

@suztomo suztomo Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's finding pom.xml within the $MODULE directory only. It does not try to find other 100 pom.xml files in other modules.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more thorough, if it did? Just scan all pom.xml's for the version ref.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unnecessarily slow. If you have a module that references a version in another module, then it makes sense. Do you know such module?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be the case in at least java-asset.

meltsufin
meltsufin reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do you want to add this to bootstrap.sh and the generated_files_sync.yaml checks?

@suztomo
Copy link
Member Author

suztomo commented Oct 6, 2022

@meltsufin Added this script to bootstrap.sh and added steps in generated_files_sync.yaml checks.

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2022
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Oct 6, 2022
@suztomo
Copy link
Member Author

suztomo commented Oct 6, 2022

Bootstrap failed. 'remote: Permission to googleapis/google-cloud-java.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/googleapis/google-cloud-java.git/': The requested URL returned error: 403'. This seems irrelevant.

@suztomo
Copy link
Member Author

suztomo commented Oct 6, 2022 

[ERROR] Errors: 
[ERROR] com.google.cloud.dataproc.v1.it.ITSystemTest.null
[ERROR]   Run 1: ITSystemTest.beforeClass:79 » Execution com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Insufficient 'CPUS' quota. Requested 12.0, available 2.0.
[ERROR]   Run 2: ITSystemTest.afterClass:93 NullPointer

@suztomo suztomo merged commit 3627152 into googleapis:main Oct 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OwlBot is modifying versions that should be managed by Release Please
2 participants
@suztomo @meltsufin