-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: consolidate configuration in google-cloud-pom-parent and google-cloud-jar-parent #8521
Conversation
If the root pom.xml has dependencyManagement section, ensure the small BOMs do not inherit the root pom.xml (I remember you have a pull request that fixes it. Where is it now?) |
@suztomo The script is |
@suztomo Do we need a parent at all for the boms? |
The parent is for release plugins. |
This reverts commit fdff9be.
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this pull request, can you add few paragraphs in README.md (or somewhere) that explain why we introduce google-cloud-pom-parent
and google-cloud-jar-parent
, and their roles (What kinds of elements should they have)? The paragraphs should cover the things you verbally explained yesterday and the maintainers 1 year later will immediately understand the design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think google-cloud-gapic-bom, google-cloud-pom-parent, and google-cloud-jar-parent all should have the same value but currently it's maintained by different key such as {x-version-update:google-cloud-jar-parent:current}
. Can you set them with 1 key?
True, but for now I like to keep the convention of the annotation matching the artifactId. I now have scripts that rely on this. |
Added repository structure documentation: 512f907. |
pom.xml
and the newgoogle-cloud-jar-parent
.consolidate_config.sh
script to help apply the change across all modulesFixes: #8543
Fixes: #8530
Fixes: #8522
Fixes: #8548