Regenerate spanner client

[yoshi-automation]

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-spanner/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:f1a2e851e5e012c59e1da4125480bb19878f86a4e7fac4f375f2e819956b5aa3
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 178 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 76 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 25 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 30 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

[kolea2]

@olavloite can you take a look at the failing tests here? I think they are asserting on the current retry behavior so will need to be changed.

[olavloite]

@kolea2 #6065 should fix the test failure.

What does surprise me a little bit is that the retry settings for the following methods have been changed from idempotent to non-idempotent:

• createDatabase
• createInstance
• updateInstance

While updateDatabaseDdl is still configured as idempotent.

I understand why the create... methods have been changed, but regarding the update... methods I have a couple of questions:

• updateDatabaseDdl: Shouldn't this also be non-idempotent? Executing an operation like CREATE TABLE FOO ... is not something that could normally be retried without side effects.
• updateInstance: As far as I can see, this method can only be used to set the name, node count and labels. Setting the same values multiple times should (as far as I can tell) not have any side effects, which would allow this method to be configured as idempotent.

[kolea2]

Thanks @olavloite! I will bring this up with the Spanner team.