Expand test coverage for GrpcResultSet and runWithRetries() by nithinsujir · Pull Request #3702 · googleapis/google-cloud-java

nithinsujir · 2018-09-19T16:11:17Z

The coverage is now at 84% for Instructions and 81% for Branches.

Signed-off-by: Nithin Nayak Sujir <nsujir@google.com>

nithinsujir · 2018-09-19T18:05:19Z

snehashah16

if possible, could u also add code coverage stats in these reviews..

...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

+            .build());
+    consumer.onCompleted();
+    resultSet.next();
+    assertThat(resultSet.getBoolean(0));


...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

+
+    resultSet.next();
+    Double d = resultSet.getDouble(0);
+    assertThat(d.equals(Double.MIN_VALUE));


...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

+    consumer.onCompleted();
+    resultSet.next();
+
+    assertThat(resultSet.getDoubleArray(0).equals(dArray));


...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

+    consumer.onCompleted();
+
+    resultSet.next();
+    assertThat(resultSet.getTimestamp(0) == Timestamp.parseTimestamp("0001-01-01T00:00:00Z"));


...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

+    consumer.onCompleted();
+
+    resultSet.next();
+    assertThat(resultSet.getDate(0).compareTo(Date.fromYearMonthDay(2018, 5, 29)) == 0);


nithinsujir · 2018-09-19T21:30:40Z

Cool, I'll change it. Thanks.

…

On Wed, Sep 19, 2018 at 2:24 PM Michael Darakananda < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In google-cloud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java <#3702 (comment)> : > + } + + @test + public void getDoubleArray() { + double[] dArray = {Double.MAX_VALUE, Double.MIN_VALUE, 111, 333, 444, 0, -1, -2234}; + + consumer.onPartialResultSet( + PartialResultSet.newBuilder() + .setMetadata(makeMetadata(Type.struct( + Type.StructField.of("f", Type.array(Type.float64()))))) + .addValues(Value.float64Array(dArray).toProto()) + .build()); + consumer.onCompleted(); + resultSet.next(); + + assertThat(resultSet.getDoubleArray(0).equals(dArray)); I *think* it's fine? The Javadoc doesn't seem to think this is deprecated https://google.github.io/truth/api/0.42/com/google/common/truth/PrimitiveDoubleArraySubject.html — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3702 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHP1lwmAqcyzOankuo5A9Pbpw2DCqlKks5ucrX-gaJpZM4WwgA4> .

...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

+
+    resultSet.next();
+    Double d = resultSet.getDouble(0);
+    assertThat(d.equals(Double.MIN_VALUE));


...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

+    Double d = resultSet.getDouble(0);
+    assertThat(d.equals(Double.MIN_VALUE));
+    resultSet.next();
+    assertThat(resultSet.getDouble(0)).isWithin(0.0).of(Double.MAX_VALUE);


...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

+    consumer.onCompleted();
+
+    resultSet.next();
+    assertThat(resultSet.getDate(0)


...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

    assertThat(row).isEqualTo(copy);
  }
+
+  @Test


… longer names

snehashah16

LGTM

...d-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

    assertThat(row).isEqualTo(copy);
  }
+
+  @Test


...oud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerImplTest.java

+            }
+          });
+    } catch (SpannerException e) {
+      assertThat(e.getErrorCode() == ErrorCode.INTERNAL);


pongad · 2018-09-26T18:57:20Z

@nithinsujir This LGTM, are we good to merge?

nithinsujir · 2018-09-26T19:25:11Z

@pongad Yes, this is good to go, thanks.

Expand test coverage for GrpcResultSet and runWithRetries()

07b735d

Signed-off-by: Nithin Nayak Sujir <nsujir@google.com>

nithinsujir requested a review from pongad as a code owner September 19, 2018 16:11

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2018

nithinsujir changed the title ~~WIP: Expand test coverage for GrpcResultSet and runWithRetries()~~ Expand test coverage for GrpcResultSet and runWithRetries() Sep 19, 2018

nithinsujir requested a review from snehashah16 September 19, 2018 17:31

Fix codacy warnings

98ab6ce

snehashah16 reviewed Sep 19, 2018

View reviewed changes

Use recommended Truth assertions

5930789

pongad reviewed Sep 19, 2018

View reviewed changes

Use isEqualTo() for getDateList()

d6a2599

Use isEqualTo() for getDoubleArray()

0cd0fe6

snehashah16 reviewed Sep 21, 2018

View reviewed changes

Fix review comments: assert resultset.next(), missed getDouble check,…

5bf5004

… longer names

snehashah16 approved these changes Sep 25, 2018

View reviewed changes

Use .isEqualTo()

856a6d4

pongad merged commit c79f280 into googleapis:master Sep 27, 2018

nithinsujir deleted the covg3 branch September 28, 2018 15:46

Conversation

nithinsujir commented Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nithinsujir commented Sep 19, 2018

Uh oh!

snehashah16 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

nithinsujir commented Sep 19, 2018 via email

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

snehashah16 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Sep 26, 2018

Uh oh!

nithinsujir commented Sep 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nithinsujir commented Sep 19, 2018 •

edited

Loading