pubsub: make poll wait for messages #2112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning immediately if no messages are available, poll now waits for messages. Fixes #2108.
googlebot
added
the
cla: yes
davidtorres
reviewed
Jun 5, 2017
| PullRequest.newBuilder() | ||
| .setSubscription(subscription) | ||
| .setMaxMessages(maxDesiredPulledMessages) | ||
| .build()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| new FutureCallback<PullResponse>() { | ||
| @Override | ||
| public void onSuccess(PullResponse pullResponse) { | ||
| if (pullResponse.getReceivedMessagesCount() == 0) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@davidtorres PTAL |
|
Changes Unknown when pulling ce47990 on pongad:pull-wait into ** on GoogleCloudPlatform:master**. |
Member
|
LGTM - this seems to fulfill the requested change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning immediately if no messages are available,
poll now waits for messages.
Fixes #2108.
@davidtorres @haakonringberg