Fix Datastore - call to setNamespace fails under certain Locales #2037
Conversation
…leapis#1957 Also checked other usages of String.format(), they seem ok. One potentially problematic place is com.google.cloud.testing.Version#toString(), but it is testing code.
googlebot
added
the
cla: yes
vam-google
changed the title
|
Changes Unknown when pulling e775f82 on vam-google:master into ** on GoogleCloudPlatform:master**. |
shinfan
left a comment
shinfan
left a comment
There was a problem hiding this comment.
The fix looks good to me. Do we wanna update the tests for cases like this?
|
First I wanted to add a test, but then... What to test? We cannot test all possible outcomes from all possible locales. I believe what we should do is to avoid using String.format() to stings, which are consumed programmatically (like in this case). Since String.format() relies on Local, it means it is supposed to be used to construct human-readable messages only. So I checked usage of String.format in the rest of the package and it seems we are fine (it is either %s (I believe it is locale-independent) or in testing, or more specific %d, which should be locale-independent anyways). |
* chore(main): release 2.33.3 * chore: generate libraries at Sat Jan 24 01:25:16 UTC 2026 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
4 participants
#1957
Also checked other usages of String.format(), they seem ok. One potentially problematic place is com.google.cloud.testing.Version#toString(), but it is testing code.