properly stop MessageDispatcher if Subscriber fails #1665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PollingSubscriberConnection fails, it calls `notifyFailed`. Subscriber listens to this failure and stops all connections before failing itself. Stopping connections is implemented with `stopAsync`. The problem is with the connection that originally failed. Since it has already entered the FAILED state, it cannot be stopped by `stopAsync`. Consequently, this leaks a MessageDispatcher. This commit makes the connection explicitly stop itself before notifying the Subscriber that it has failed.
googlebot
added
the
cla: yes
|
Changes Unknown when pulling b42d9f4 on pongad:subscriber-stop into ** on GoogleCloudPlatform:master**. |
Member
|
LGTM |
davidtorres
approved these changes
Mar 1, 2017
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PollingSubscriberConnection fails, it calls
notifyFailed.Subscriber listens to this failure and stops all connections before
failing itself.
Stopping connections is implemented with
stopAsync.The problem is with the connection that originally failed.
Since it has already entered the FAILED state, it cannot be stopped
by
stopAsync.Consequently, this leaks a MessageDispatcher.
This commit makes the connection explicitly stop itself before notifying
the Subscriber that it has failed.
cc @davidtorres