Skip to content

Conversation

@gene-telligent
Copy link

This has been exposed through the protobuf API already; I just coded in a method to access it through the Java SDK.

See: https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.load.autodetect

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 81.106% when pulling 1ba92ed on telligent-data:feature/bq-schema-autodetect into a599972 on GoogleCloudPlatform:master.

@garrettjonesgoogle
Copy link
Member

@tswast could you take a look?

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Thanks for adding support for this feature. It's much appreciated.

@tswast
Copy link
Contributor

tswast commented Mar 1, 2017

@garrettjonesgoogle Is there an @beta annotation we should be adding to these features?

@garrettjonesgoogle
Copy link
Member

@tswast I don't think we've been putting annotations on methods to match the support level of the underlying API. It gets tricky when the support level of the underlying API changes, because then we might have to keep revising the annotations in the client library to match.

The tag we have been using for features that might change in the client library is @ExperimentalApi (defined in protobuf).

@gene-telligent gene-telligent force-pushed the feature/bq-schema-autodetect branch from 1ba92ed to e6660b8 Compare March 23, 2017 01:05
@gene-telligent
Copy link
Author

Hi all,

I've rebased the commit with the latest from master (waiting on CI builds to complete now, but internal running of the tests raised no errors).

I didn't use @ExperimentalApi as it seems to be an annotation reserved for the SPI libraries.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e6660b8 on telligent-data:feature/bq-schema-autodetect into ** on GoogleCloudPlatform:master**.

@tswast
Copy link
Contributor

tswast commented Mar 23, 2017

@garrettjonesgoogle could you merge? I haven't been tracking when releases are happening. I don't want to step on the release process again.

@garrettjonesgoogle garrettjonesgoogle merged commit 50856d6 into googleapis:master Mar 23, 2017
@gene-telligent gene-telligent deleted the feature/bq-schema-autodetect branch March 23, 2017 17:39
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
* chore(main): release 2.24.2

* chore: generate libraries at Wed Nov  6 21:13:30 UTC 2024

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants