Skip to content

feat(gax): implement startUploadCallable for resumable uploads - #14139

Draft
whowes wants to merge 1 commit into
whowes/resumable-upload-clientfrom
whowes/resumable-upload-start
Draft

feat(gax): implement startUploadCallable for resumable uploads#14139
whowes wants to merge 1 commit into
whowes/resumable-upload-clientfrom
whowes/resumable-upload-start

Conversation

@whowes

@whowes whowes commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The implementation uses a custom HttpJsonClientCall.Listener to extract X-Goog-Upload-URL and X-Goog-Upload-Chunk-Granularity headers to be returned in a ResumableUploadSession.

gemini-code-assist[bot]

This comment was marked as outdated.

Sign in to view

@whowes whowes changed the title whowes/resumable upload start feat(gax): implement startUpload in HttpJsonResumableUploadClient Aug 19, 2026
@whowes whowes mentioned this pull request Aug 19, 2026
Draft
@whowes
whowes force-pushed the whowes/resumable-upload-start branch 2 times, most recently from 8d52acf to 7df9201 Compare August 20, 2026 00:06
@whowes

whowes commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@whowes
whowes force-pushed the whowes/resumable-upload-start branch from 7df9201 to 4253855 Compare August 20, 2026 00:10
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 20, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces HttpJsonResumableUploadClient to support resumable uploads over HTTP/JSON, along with a comprehensive suite of unit tests. The feedback suggests validating that the parsed chunk granularity is strictly positive to prevent potential arithmetic errors or infinite loops.

Comment thread ...va/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonResumableUploadClient.java
@whowes
whowes force-pushed the whowes/resumable-upload-start branch from 4253855 to 798876d Compare August 20, 2026 01:38
@whowes whowes changed the title feat(gax): implement startUpload in HttpJsonResumableUploadClient feat(gax): implement startUploadCallable for resumable uploads Aug 21, 2026
@whowes
whowes force-pushed the whowes/resumable-upload-start branch from 798876d to a071113 Compare August 21, 2026 00:37
@sonarqubecloud

sonarqubecloud Bot commented Aug 21, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
46.6% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud

sonarqubecloud Bot commented Aug 21, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@whowes