test: skip unit tests for modules that have their own split tests#11960
Open
test: skip unit tests for modules that have their own split tests#11960
Conversation
Contributor
|
I thought we agreed that unit tests are OK to be included because they should be relatively fast. Do you have examples of unit tests that are non-trivial and take a lot longer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the new split repos are migrating to the monorepo, we actually want to skip those unit tests when running the unit tests on the entire repo. This is because the unit tests for the migrated repos may be non-trivial and take a lot longer than the rest of the tests.
This is accomplished by adding a new profile called
bulkTestswhich we set when running the "full" unit tests suite (no run on the split unit tests). When activated, the modules that migrated into the monorepo have that profile defined that will set theskipTestsmaven property (which skips those tests).