Skip to content

chore: skip java-samples using maven-deploy-plugin's skip#11592

Merged
suztomo merged 2 commits intomainfrom
skip_java-samples
May 21, 2025
Merged

chore: skip java-samples using maven-deploy-plugin's skip#11592
suztomo merged 2 commits intomainfrom
skip_java-samples

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented May 20, 2025

As part of the migration from OSSRH to Central Portal, we stop
using nexus-staging-maven-plugin, in favor of the (pure)
maven-deploy-plugin.
This means that if some modules are skipped using
nexus-staging-maven-plugin's skipNexusStagingDeployMojo property,
we need to convert it to maven-deploy-plugin's skip property.

As part of the migration from OSSRH to Central Portal, we stop
using nexus-staging-maven-plugin, in favor of the (pure)
maven-deploy-plugin.
This means that if some modules are skipped using
nexus-staging-maven-plugin's skipNexusStagingDeployMojo property,
we need to convert it to maven-deploy-plugin's skip property.
@suztomo suztomo requested review from a team, chingor13 and mpeddada1 May 20, 2025 22:21
chingor13
chingor13 previously approved these changes May 20, 2025
</dependencies>

<build>
<pluginManagement>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do both?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@suztomo suztomo merged commit c943a01 into main May 21, 2025
31 of 32 checks passed
@suztomo suztomo deleted the skip_java-samples branch May 21, 2025 14:36
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
* chore: skip java-samples using maven-deploy-plugin's skip

As part of the migration from OSSRH to Central Portal, we stop
using nexus-staging-maven-plugin, in favor of the (pure)
maven-deploy-plugin.
This means that if some modules are skipped using
nexus-staging-maven-plugin's skipNexusStagingDeployMojo property,
we need to convert it to maven-deploy-plugin's skip property.

* revert nexus-sonatype-maven-plugin
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
* chore: skip java-samples using maven-deploy-plugin's skip

As part of the migration from OSSRH to Central Portal, we stop
using nexus-staging-maven-plugin, in favor of the (pure)
maven-deploy-plugin.
This means that if some modules are skipped using
nexus-staging-maven-plugin's skipNexusStagingDeployMojo property,
we need to convert it to maven-deploy-plugin's skip property.

* revert nexus-sonatype-maven-plugin
lqiu96 pushed a commit that referenced this pull request Jul 7, 2025
* chore: skip java-samples using maven-deploy-plugin's skip

As part of the migration from OSSRH to Central Portal, we stop
using nexus-staging-maven-plugin, in favor of the (pure)
maven-deploy-plugin.
This means that if some modules are skipped using
nexus-staging-maven-plugin's skipNexusStagingDeployMojo property,
we need to convert it to maven-deploy-plugin's skip property.

* revert nexus-sonatype-maven-plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants