Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for copyright header #8406

Closed
suztomo opened this issue Sep 15, 2022 · 3 comments · Fixed by #9986
Closed

Add a check for copyright header #8406

suztomo opened this issue Sep 15, 2022 · 3 comments · Fixed by #9986
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Sep 15, 2022

Follow up of #8402
@suztomo suztomo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 15, 2022
@meltsufin
Copy link
Member

More info: https://github.com/googleapis/repo-automation-bots/tree/main/packages/header-checker-lint

@suztomo suztomo added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 28, 2022
@meltsufin
Copy link
Member

I enabled it for this repo, but still need to see if starts showing up in PRs.

@suztomo
Copy link
Member Author

suztomo commented Oct 23, 2023

It's there. For example #9985 has

image

suztomo added a commit that referenced this issue Oct 23, 2023
@suztomo
ci: header-check as required
9091f8e 
Fixes #8406
@suztomo suztomo mentioned this issue Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: header-check as required googleapis/google-cloud-java
2 participants
@suztomo @meltsufin