Skip to content

bigquery: tabledata.list tracking #2591

Description

@pongad

This issue tracks things we need to migrate query to use tabledata.list instead of getQueryResults RPC.
Work is in bq-perf branch.

  • Remove InternalApi QueryResponse type
  • Remove InternalApi BigQuery.getQueryResults
    • Use getJob().getQueryResults instead
  • Give QueryResults fewer fields (bigquery: give QueryResult fewer fields #2592)
    • To get details of a job, use Job
  • Should Job.getQueryResults wait for query to finish?
  • What should BigQuery.query do?
    • alias of create?
    • return completed job?
    • return iterator?
      • What option should it accept?
      • Accept option for iterating, use default option for waiting?
  • Consider unified types of Job.getQueryResults and BigQuery.listTableData
  • Make sure benchmark actually improves
  • Make sure we don't retrogress on small queries

Activity

  1. added
    api: bigqueryIssues related to the BigQuery API.
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Nov 8, 2017
  2. self-assigned this
    on Nov 8, 2017
  3. pongad commented on Nov 8, 2017

    @pongad
    ContributorAuthor

    @vam-google @tswast I'm just copying from notes of meeting we had a couple of weeks ago. Could you check that we're on the same page?

  4. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    on Nov 8, 2017
  5. tswast commented on Nov 10, 2017

    @tswast
    Contributor

    👍

    Regarding "What should BigQuery.query do?" my preference is "alias of create". But the other options may be acceptable if any exceptions thrown while waiting for the job make it easy to get the full job resource so that the user can investigate errors further.

  6. pongad commented on Jan 9, 2018

    @pongad
    ContributorAuthor

    Everything done now. We're going to merge back to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigqueryIssues related to the BigQuery API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions