test(bigtable): Clean up test clusters #9270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
gkevinzheng
approved these changes
Jan 18, 2024
kolea2
approved these changes
Jan 23, 2024
| } | ||
| } else { | ||
| // Delete clusters created in existing instances | ||
| clusters, err := iac.Clusters(ctx, instanceInfo.Name) |
There was a problem hiding this comment.
to confirm, is there ever a case where we want to keep the instance and cluster?
There was a problem hiding this comment.
We don't want to keep the ones created by the integration test.
The ones created by user will not be deleted.
User can specify an existing instance and a existing cluster to use in tests via environment variables:
GCLOUD_TESTS_BIGTABLE_INSTANCE
GCLOUD_TESTS_BIGTABLE_CLUSTER
There are prefix checks at line 137 and 154 to determine whether resource was created by the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Test fails with error:
Cause:
Cluster created in previous run did not get cleaned up
Fix: