Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): expose dataset MaxTimeTravelHours #7706

Merged

Conversation

shollyman
Copy link
Contributor

No description provided.

@shollyman shollyman requested review from a team as code owners April 7, 2023 17:10
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the BigQuery API. labels Apr 7, 2023
@shollyman shollyman requested a review from codyoss April 7, 2023 17:10
@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Apr 7, 2023
@@ -58,6 +58,10 @@ type DatasetMetadata struct {
// More information: https://cloud.google.com/bigquery/docs/reference/standard-sql/collation-concepts
DefaultCollation string

// MaxTimeTravelHours represents the number of hours for the max time travel for all tables
// in the dataset. Durations are rounded towards zero for the nearest hourly value.
MaxTimeTravelHours time.Duration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I get the intention with the word Hours here, but it does feel a little off since this is just a duration. Maybe drop hours. Also maybe TraversalTime instead of TimeTravel -- although it does sound cool 🚀

@codyoss codyoss removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 7, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 22a666c into googleapis:main Apr 7, 2023
shollyman added a commit to shollyman/google-cloud-go that referenced this pull request Apr 7, 2023
PR googleapis#7706 submitted
before the edit to shorten the name landed.  This PR updates it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants