chore(storage): handle object metadata (grpc) #7688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BrennaEpp
commented
Apr 4, 2023
BrennaEpp
commented
- t.Cleanup does not work with gRPC (connection is closed before t.Cleanup runs - probably a question of using defer elsewhere)
product-auto-label
bot
added
size: s
tritone
reviewed
Apr 5, 2023
storage/grpc_client.go
Outdated
| // TODO(cathyo): Handle metadata. Pending b/230510191. | ||
|
|
||
| if uattrs.Metadata != nil { | ||
| fieldMask.Paths = append(fieldMask.Paths, "metadata") |
There was a problem hiding this comment.
Should we specify which keys are being updated here using dot notation? I'm a bit confused so maybe we can discuss tomorrow.
There was a problem hiding this comment.
Discussed offline, this was fine too but it'll be clearer to explicitly send added keys using dot notation, and we can do the same for deleted keys once/if we add support for deleting specific keys.
tritone
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.