Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): gRPC support customer encryption #6994

Merged
merged 4 commits into from
Nov 7, 2022
Merged

chore(storage): gRPC support customer encryption #6994

merged 4 commits into from
Nov 7, 2022

Conversation

noahdietz
Copy link
Contributor

Enables use of customer provided encryption for Object media operations (Read, Rewrite, Write (including resumable), etc.).

Enables both TestIntegration_Encryption and TestIntegration_KMS for gRPC.

@noahdietz noahdietz requested review from a team as code owners November 3, 2022 21:43
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the Cloud Storage API. labels Nov 3, 2022
tritone
tritone reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, otherwise LGTM! Thanks Noah.

storage/grpc_client.go Outdated Show resolved Hide resolved
@noahdietz noahdietz merged commit a9cea38 into googleapis:main Nov 7, 2022
@noahdietz noahdietz deleted the grpc-encrypt branch November 7, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @tritone