chore(datastore): fix for flaky integration tests #6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
quartzmo
reviewed
Nov 4, 2022
datastore/integration_test.go
Outdated
| // exposed in anyway in the response. | ||
| err = client.Get(ctx, k, &got) | ||
| if err != nil { | ||
| t.Errorf("client.Get: %v", err) |
There was a problem hiding this comment.
Should this be r.Errorf to ensure the retry works correctly?
Btw, have you observed the retries working?
quartzmo
reviewed
Nov 4, 2022
datastore/integration_test.go
Outdated
| } | ||
|
|
||
| // Wait a little bit for eventual consistency to catch up. | ||
| time.Sleep(time.Duration(10 * math.Pow(10, 9))) |
There was a problem hiding this comment.
Is it really worth waiting 10s every time? I think this is only worth it if it's guaranteed to take that long, otherwise might as well try right away, or after a shorter wait.
There was a problem hiding this comment.
I tried several different time lengths from 1-10 seconds to ensure consistent test success. 10s was the lowest value that seemed to work every time (locally).
There was a problem hiding this comment.
You know what, it looks like the issue was that I didn't hook into the retries correctly :). Nice catch!
product-auto-label
bot
added
size: s
telpirion
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
quartzmo
approved these changes
Nov 7, 2022
telpirion
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6939
Fixes #6938