feat(bigquery): widen retry predicate #6976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds 500,504 http response codes for the default retry predicate on unary retries. This doesn't introduce job-level retries (jobs must be recreated wholly, they can't be effectively restarted), so the primary risk of this change is terminal job state propagating into the HTTP response code of one of the polling methods (e.g. job.getQueryResults, jobs.get, etc). In this situation, the primary risk is that job execution may appear to hang indefinitely. Related: googleapis#5248
product-auto-label
bot
added
size: s
alvarowolfx
reviewed
Nov 3, 2022
| @@ -237,8 +243,10 @@ func retryableError(err error, allowedReasons []string) bool { | |||
| } | |||
| } | |||
| } | |||
| if e.Code == http.StatusServiceUnavailable || e.Code == http.StatusBadGateway { | |||
| return true | |||
| for _, code := range retry5xxCodes { | |||
There was a problem hiding this comment.
The function comment needs to be updated, as it mentions just the 502 and 503 errors - It also considers 502 ("Bad Gateway") and 503 ("Service Unavailable") errors retryable;
alvarowolfx
approved these changes
Nov 3, 2022
There's some hooks we can consider such as https://pkg.go.dev/github.com/googleapis/gax-go/v2#WithRetry Storage rolled their own client-level settings: https://pkg.go.dev/cloud.google.com/go/storage#Client.SetRetry |
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 500,504 http response codes for the default retry predicate on unary retries.
This doesn't introduce job-level retries (jobs must be recreated wholly, they can't be effectively restarted), so the primary risk of this change is terminal job state propagating into the HTTP response code of one of the polling methods (e.g. job.getQueryResults, jobs.get, etc). In this situation, job execution may appear to hang indefinitely or until context cancellation/expiry.
Related: #5248