Skip to content

fix(bigquery): revert to useInt64Timestamp for REST format options#13789

Merged
shollyman merged 1 commit intogoogleapis:mainfrom
kurochan:bigquery-format-options-regression
Feb 5, 2026
Merged

fix(bigquery): revert to useInt64Timestamp for REST format options#13789
shollyman merged 1 commit intogoogleapis:mainfrom
kurochan:bigquery-format-options-regression

Conversation

@kurochan
Copy link
Contributor

@kurochan kurochan commented Feb 5, 2026

Revert BigQuery REST format options to useInt64Timestamp to avoid the
timestamp_output_format is not supported yet 400 ERRORs introduced in v1.73.0.

Related: #13788

@kurochan kurochan requested review from a team as code owners February 5, 2026 07:24
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Feb 5, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kurochan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a critical fix for the BigQuery client library, reverting a recent change that caused timestamp_output_format is not supported yet errors when interacting with the BigQuery REST API. By switching back to the useInt64Timestamp option, the library restores correct timestamp handling and ensures seamless operation for users.

Highlights

  • Reverted Timestamp Format: The BigQuery REST API calls now use useInt64Timestamp instead of timestamp_output_format for timestamp formatting.
  • Error Resolution: This change specifically addresses and resolves the timestamp_output_format is not supported yet 400 ERRORs that appeared in v1.73.0.
  • Constant Update: The internal constant defaultTimestampWireFormat has been replaced by defaultUseInt64Timestamp to align with the new API parameter.
Changelog
  • bigquery/iterator.go
    • Changed the constant defaultTimestampWireFormat (string "INT64") to defaultUseInt64Timestamp (boolean true).
    • Modified fetchTableResultPage to call FormatOptionsUseInt64Timestamp instead of FormatOptionsTimestampOutputFormat.
    • Modified fetchJobResultPage to call FormatOptionsUseInt64Timestamp instead of FormatOptionsTimestampOutputFormat.
  • bigquery/job.go
    • Modified waitForQuery to call FormatOptionsUseInt64Timestamp instead of FormatOptionsTimestampOutputFormat.
  • bigquery/query.go
    • Updated probeFastPath to set UseInt64Timestamp in bq.DataFormatOptions instead of TimestampOutputFormat.
  • bigquery/query_test.go
    • Updated TestProbeFastPath to reflect the change from TimestampOutputFormat to UseInt64Timestamp in expected bq.DataFormatOptions for test cases.
Activity
  • The pull request was created by kurochan.
  • No human activity (comments, reviews, approvals) has been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the BigQuery REST format options from using timestamp_output_format back to useInt64Timestamp to fix 400 errors caused by an unsupported feature. The changes are applied consistently across iterator.go, job.go, query.go, and query_test.go, replacing the defaultTimestampWireFormat constant and its usage with defaultUseInt64Timestamp. The modifications appear correct and effectively address the bug.

@shollyman shollyman self-assigned this Feb 5, 2026
@shollyman
Copy link
Contributor

Thanks for this!

@shollyman shollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2026
@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Feb 5, 2026
@shollyman shollyman merged commit bdcc2f8 into googleapis:main Feb 5, 2026
10 of 11 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 5, 2026
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 5, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.

Librarian Version: v0.8.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f
<details><summary>bigquery: 1.73.1</summary>

## [1.73.1](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.73.0...bigquery/v1.73.1) (2026-02-05)

### Bug Fixes

* revert to useInt64Timestamp for REST format options (#13789) ([bdcc2f8](https://togithub.com/googleapis/google-cloud-go/commit/bdcc2f80))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants