fix(bigquery): revert to useInt64Timestamp for REST format options#13789
Conversation
Summary of ChangesHello @kurochan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request provides a critical fix for the BigQuery client library, reverting a recent change that caused Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts the BigQuery REST format options from using timestamp_output_format back to useInt64Timestamp to fix 400 errors caused by an unsupported feature. The changes are applied consistently across iterator.go, job.go, query.go, and query_test.go, replacing the defaultTimestampWireFormat constant and its usage with defaultUseInt64Timestamp. The modifications appear correct and effectively address the bug.
|
Thanks for this! |
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f <details><summary>bigquery: 1.73.1</summary> ## [1.73.1](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.73.0...bigquery/v1.73.1) (2026-02-05) ### Bug Fixes * revert to useInt64Timestamp for REST format options (#13789) ([bdcc2f8](https://togithub.com/googleapis/google-cloud-go/commit/bdcc2f80)) </details>
Revert BigQuery REST format options to
useInt64Timestampto avoid thetimestamp_output_format is not supported yet400 ERRORs introduced in v1.73.0.Related: #13788