Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/action_syntax.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ jobs:
permissions:
pull-requests: write
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- uses: reviewdog/action-actionlint@v1
16 changes: 8 additions & 8 deletions .github/workflows/apidiff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,21 @@
scan_changes:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
ref: main
- name: Get main commit
id: main
run: echo "hash=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT

Check warning on line 21 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:1:38: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/apidiff.yml:21:7: shellcheck reported issue in this script: SC2086:info:1:38: Double quote to prevent globbing and word splitting [shellcheck]
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: '1.25.x'
- name: Get changed directories
id: changed_dirs
# Ignore changes to the internal and root directories.
# Ignore added files with --diff-filter=a.
run: |

Check warning on line 30 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:9:19: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/apidiff.yml:30:7: shellcheck reported issue in this script: SC2086:info:9:19: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 30 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:8:47: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/apidiff.yml:30:7: shellcheck reported issue in this script: SC2086:info:8:47: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 30 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/apidiff.yml:30:7: shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck]
dirs=$(cd internal/actions; go run ./cmd/changefinder -q --diff-filter=a --dir=${{ github.workspace }})
if [ -z "$dirs" ]
then
Expand All @@ -52,17 +52,17 @@
strategy:
matrix: ${{ fromJson(needs.scan_changes.outputs.changed_dirs) }}
steps:
- uses: actions/setup-go@v5
- uses: actions/setup-go@v6
with:
go-version: '1.25.x'
- name: Install latest apidiff
run: go install golang.org/x/exp/cmd/apidiff@latest
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
ref: main
- name: Create baseline
id: baseline
run: |

Check warning on line 65 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:2:41: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/apidiff.yml:65:7: shellcheck reported issue in this script: SC2086:info:2:41: Double quote to prevent globbing and word splitting [shellcheck]
export CHANGED=${{ matrix.changed }}
echo pkg="${CHANGED//\//_}_pkg.main" >> $GITHUB_OUTPUT
- name: Create Go package baseline
Expand All @@ -73,7 +73,7 @@
name: ${{ steps.baseline.outputs.pkg }}
path: ${{ matrix.changed }}/${{ steps.baseline.outputs.pkg }}
retention-days: 1
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Download baseline package data
uses: actions/download-artifact@v6
with:
Expand All @@ -88,7 +88,7 @@
# as it is likely a new method added to the gRPC client stub interface, which is non-breaking.
env:
PR_HEAD_REF: ${{ github.event.pull_request.head.ref }}
run: |

Check warning on line 91 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:8:40: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/apidiff.yml:91:7: shellcheck reported issue in this script: SC2086:info:8:40: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 91 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:10:41: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/apidiff.yml:91:7: shellcheck reported issue in this script: SC2086:info:10:41: Double quote to prevent globbing and word splitting [shellcheck]
cd ${{ matrix.changed }}
apidiff -m -incompatible ${{ steps.baseline.outputs.pkg }} . > diff.txt
if [[ "$PR_HEAD_REF" == librarian-* ]]; then
Expand Down Expand Up @@ -121,7 +121,7 @@
# review, even if they don't block the PR.
- name: Add breaking change label
if: ${{ steps.detect.outputs.breaking_change_found == 'true' && !github.event.pull_request.head.repo.fork }}
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
github.rest.issues.addLabels({
Expand All @@ -137,7 +137,7 @@
# the failed presubmit check is the primary signal.
- name: Post breaking change details as a comment
if: ${{ steps.ga_check.outcome == 'success' && !github.event.pull_request.head.repo.fork }}
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const fs = require('fs');
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ jobs:
go: [ '1.24', '1.25']
folders: ['bigtable']
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
path: google-cloud-go
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
repository: googleapis/cloud-bigtable-clients-test
ref: v0.0.3
path: cloud-bigtable-clients-test
- uses: actions/setup-go@v5
- uses: actions/setup-go@v6
with:
go-version: ${{ matrix.go }}
- run: go version
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/third_party_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
changed_gomods:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 2
- uses: actions/setup-go@v5
- uses: actions/setup-go@v6
with:
go-version: 1.25.x
- name: Find modified go.mod files
Expand All @@ -45,7 +45,7 @@ jobs:
strategy:
matrix: ${{ fromJson(needs.changed_gomods.outputs.mods) }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- run: |
cd internal/actions
go run ./internal/actions/cmd/thirdpartycheck -q --dir=${{ github.workspace }} -mod ${{ matrix.mods }}/go.mod
4 changes: 2 additions & 2 deletions .github/workflows/vet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
vet:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: '1.25.x'
- name: Install tools
Expand Down
Loading