-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: update spanner test module #13639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update spanner test module #13639
Conversation
This PR corrects a test usage that wasn't automatically upgraded by vuln updates
Summary of ChangesHello @shollyman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the health and security of the Spanner OpenTelemetry test module by updating several Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several indirect dependencies in the go.mod and go.sum files for the Spanner test module. The changes appear to be aimed at resolving security vulnerabilities. While the updates are a good step, I've noticed that not all dependencies are being updated to their latest available versions. I've added a comment suggesting a more comprehensive update to ensure all dependencies are current, which would maximize the security benefits. Otherwise, the changes are correct.
| golang.org/x/crypto v0.45.0 // indirect | ||
| golang.org/x/net v0.47.0 // indirect | ||
| golang.org/x/oauth2 v0.33.0 // indirect | ||
| golang.org/x/sync v0.18.0 // indirect | ||
| golang.org/x/sys v0.37.0 // indirect | ||
| golang.org/x/text v0.30.0 // indirect | ||
| golang.org/x/sys v0.38.0 // indirect | ||
| golang.org/x/text v0.31.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that while some dependencies are being updated, they are not being moved to the latest available versions. For example:
golang.org/x/sysis updated tov0.38.0, but the latest isv0.45.0.golang.org/x/textis updated tov0.31.0, but the latest isv0.40.0.
Since this PR is for vulnerability updates, it would be best to update all dependencies to their latest versions to ensure all available security patches are applied. You can achieve this by running go get -u ./... and go mod tidy.
If you are intentionally pinning to these specific versions due to compatibility constraints, please consider adding a comment to the go.mod file to document the reason.
This PR corrects a test usage that wasn't automatically upgraded by vuln updates
This PR corrects a test usage that wasn't automatically upgraded by vuln updates