Skip to content

Conversation

@shollyman
Copy link
Contributor

This PR corrects a test usage that wasn't automatically upgraded by vuln updates

This PR corrects a test usage that wasn't automatically upgraded by vuln
updates
@shollyman shollyman requested review from a team as code owners January 16, 2026 22:57
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shollyman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining the health and security of the Spanner OpenTelemetry test module by updating several golang.org/x module dependencies. The changes ensure that the test environment utilizes the most current and secure versions of these critical Go libraries, specifically addressing issues that were not automatically resolved by previous vulnerability updates.

Highlights

  • Dependency Updates: Updated several core golang.org/x dependencies within the Spanner OpenTelemetry test module to address test usage that wasn't automatically upgraded by vulnerability updates.
  • Specific Module Upgrades: Upgraded golang.org/x/crypto from v0.43.0 to v0.45.0, golang.org/x/net from v0.46.0 to v0.47.0, golang.org/x/sys from v0.37.0 to v0.38.0, and golang.org/x/text from v0.30.0 to v0.31.0.
  • Checksum Synchronization: Synchronized go.sum to reflect the updated module versions, including new entries for golang.org/x/mod, golang.org/x/telemetry, golang.org/x/tools, and golang.org/x/term.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Jan 16, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several indirect dependencies in the go.mod and go.sum files for the Spanner test module. The changes appear to be aimed at resolving security vulnerabilities. While the updates are a good step, I've noticed that not all dependencies are being updated to their latest available versions. I've added a comment suggesting a more comprehensive update to ensure all dependencies are current, which would maximize the security benefits. Otherwise, the changes are correct.

Comment on lines 54 to 59
golang.org/x/crypto v0.45.0 // indirect
golang.org/x/net v0.47.0 // indirect
golang.org/x/oauth2 v0.33.0 // indirect
golang.org/x/sync v0.18.0 // indirect
golang.org/x/sys v0.37.0 // indirect
golang.org/x/text v0.30.0 // indirect
golang.org/x/sys v0.38.0 // indirect
golang.org/x/text v0.31.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

I've noticed that while some dependencies are being updated, they are not being moved to the latest available versions. For example:

  • golang.org/x/sys is updated to v0.38.0, but the latest is v0.45.0.
  • golang.org/x/text is updated to v0.31.0, but the latest is v0.40.0.

Since this PR is for vulnerability updates, it would be best to update all dependencies to their latest versions to ensure all available security patches are applied. You can achieve this by running go get -u ./... and go mod tidy.

If you are intentionally pinning to these specific versions due to compatibility constraints, please consider adding a comment to the go.mod file to document the reason.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 736b758 into googleapis:main Jan 16, 2026
10 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 16, 2026
@shollyman shollyman deleted the fix-spannertest branch January 16, 2026 23:49
krishnamd-jkp pushed a commit that referenced this pull request Jan 28, 2026
This PR corrects a test usage that wasn't automatically upgraded by vuln updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants