chore: librarian generate pull request: 20251231T080340Z#13528
Conversation
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the BigQuery client libraries by regenerating code from recent protobuf definitions. The core functional enhancement is the introduction of new capabilities for Bigtable external data sources, specifically enabling the use of protobuf schemas for data encoding within Bigtable columns and column families. This allows for more structured and type-safe integration of Bigtable data with protobuf-defined messages. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, generated by the Librarian CLI, updates the BigQuery client library based on recent proto changes. The main feature is the introduction of BigtableProtoConfig to support Bigtable integration, which involves adding new message types and fields to the external data configuration.
My review of the generated code has identified a couple of minor maintainability issues in the underlying protobuf definitions regarding non-sequential field numbering. While not affecting functionality, addressing these would align the code with best practices and improve future maintenance. Please see the specific comments for details.
| type BigtableProtoConfig struct { | ||
| state protoimpl.MessageState | ||
| sizeCache protoimpl.SizeCache | ||
| unknownFields protoimpl.UnknownFields | ||
|
|
||
| // Optional. The ID of the Bigtable SchemaBundle resource associated with this | ||
| // protobuf. The ID should be referred to within the parent table, e.g., | ||
| // `foo` rather than | ||
| // `projects/{project}/instances/{instance}/tables/{table}/schemaBundles/foo`. | ||
| // See [more details on Bigtable | ||
| // SchemaBundles](https://docs.cloud.google.com/bigtable/docs/create-manage-protobuf-schemas). | ||
| SchemaBundleId string `protobuf:"bytes,3,opt,name=schema_bundle_id,json=schemaBundleId,proto3" json:"schema_bundle_id,omitempty"` | ||
| // Optional. The fully qualified proto message name of the protobuf. In the | ||
| // format of "foo.bar.Message". | ||
| ProtoMessageName string `protobuf:"bytes,2,opt,name=proto_message_name,json=protoMessageName,proto3" json:"proto_message_name,omitempty"` | ||
| } |
There was a problem hiding this comment.
The field numbers in the underlying BigtableProtoConfig protobuf message are not sequential (ProtoMessageName is 2, SchemaBundleId is 3, and field 1 is missing). While this is valid, it's unconventional and can make the protobuf definition harder to maintain. It's a good practice to use sequential field numbers starting from 1. Consider renumbering the fields in the source .proto file to be 1 and 2 for better clarity and to follow common protobuf style.
| // Optional. Protobuf-specific configurations, only takes effect when the | ||
| // encoding is PROTO_BINARY. | ||
| ProtoConfig *BigtableProtoConfig `protobuf:"bytes,7,opt,name=proto_config,json=protoConfig,proto3" json:"proto_config,omitempty"` |
There was a problem hiding this comment.
The new proto_config field is assigned field number 7 in the underlying BigtableColumnFamily protobuf message, while the preceding field only_read_latest is number 5. This leaves a gap at field number 6. To improve maintainability and adhere to protobuf best practices, it's recommended to use sequential field numbers. Please consider renumbering proto_config to 6 in the source .proto file.
2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
docs: change comment indicating
enable_gemini_in_bigqueryfield for BigQuery Reservation Assignments is deprecatedPiperOrigin-RevId: 850121797
Library-IDs: bigquery
Source-link: googleapis/googleapis@94ccedca
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: expose BigtableProtoConfig for bigtable integration
PiperOrigin-RevId: 850096604
Library-IDs: bigquery/v2
Source-link: googleapis/googleapis@2c8fbf7f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add index ID to IndexPruningStats
PiperOrigin-RevId: 850096604
Library-IDs: bigquery/v2
Source-link: googleapis/googleapis@2c8fbf7f
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@535d161c
(exclusive) and
googleapis/googleapis@94ccedca
(inclusive).
Librarian Version: v0.0.0-20251218164811-cd2252e38d0a
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d