-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(auth): remove singleton and restore normal usage of otelgrpc.clientHandler #13522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @quartzmo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the gRPC transport layer's OpenTelemetry integration by removing a temporary singleton workaround for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a workaround for a memory leak in otelgrpc.NewClientHandler that has since been fixed in the upstream OpenTelemetry library. The change correctly removes the singleton pattern used to share a stats.Handler across all gRPC connections and restores the standard usage of creating a new otelgrpc.ClientHandler for each connection. This simplifies the code by removing the now-unnecessary singleton logic, including related imports, variables, and the helper function. The changes are clean, correct, and improve the maintainability of the code.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:d2dee66d7c8c1d673fac26280164ea24015b79491b7f9d6ba369e6a98ab3420c <details><summary>auth: 0.18.1</summary> ## [0.18.1](auth/v0.18.0...auth/v0.18.1) (2026-01-21) ### Bug Fixes * add InternalOptions.TelemetryAttributes for internal client use (#13641) ([3876978](38769789)) * remove singleton and restore normal usage of otelgrpc.clientHandler (#13522) ([673d4b0](673d4b05)) </details>
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:d2dee66d7c8c1d673fac26280164ea24015b79491b7f9d6ba369e6a98ab3420c <details><summary>auth: 0.18.1</summary> ## [0.18.1](auth/v0.18.0...auth/v0.18.1) (2026-01-21) ### Bug Fixes * add InternalOptions.TelemetryAttributes for internal client use (#13641) ([3876978](38769789)) * remove singleton and restore normal usage of otelgrpc.clientHandler (#13522) ([673d4b0](673d4b05)) </details>
refs: googleapis/google-api-go-client#2321
refs: googleapis/google-api-go-client#2329
refs: open-telemetry/opentelemetry-go-contrib#4226