fix(bigquery): roundtrip readonly fields

[shollyman]

Previously, the bigquery library would return errors if attempts to roundtrip values for readonly fields was attempted. This PR removes that behavior and silently propagates the values, even though we expect the service to ignore them.

Related: internal b/460218341

[gemini-code-assist]

Summary of Changes

Hello @shollyman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the BigQuery client library to modify how it handles read-only fields within metadata objects. Previously, the library would explicitly return errors if a user attempted to assign a value to a field that is considered read-only by the BigQuery service. This PR changes that behavior to silently propagate these values, aligning with a more robust and forward-compatible approach for the API.

Highlights

• Read-Only Field Handling: The BigQuery client library no longer returns errors when attempts are made to set values for read-only fields in DatasetMetadata, RoutineMetadata, and TableMetadata objects. Instead, these values are now silently propagated.
• API Flexibility: This change improves the flexibility of the API by allowing users to roundtrip values for read-only fields without encountering errors, anticipating potential future service behavior changes where these fields might become writable.
• Test Updates: Corresponding unit tests have been updated to remove assertions that previously expected errors when attempting to set read-only fields.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the BigQuery client library to allow round-tripping of read-only fields for datasets, routines, and tables. Instead of erroring out, these fields are now propagated in the request, which is a sensible change to improve the ergonomics of read-modify-write operations. The implementation is mostly consistent, but I've found one significant issue in routine.go where an assignment is reversed, causing an incorrect side effect. The associated tests have been updated accordingly to reflect the new behavior.