Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: avoid unnecessary fmt.Errorf #10752

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

perf: avoid unnecessary fmt.Errorf #10752

wants to merge 17 commits into from

Conversation

egonelbre
Copy link
Contributor

Fixes #9749

Automatically fixed with:

gofmt -w -r "fmt.Errorf(s) -> errors.New(s)" .
goimports -w .

Spanner related changes are in #10736

@egonelbre egonelbre requested review from a team and igorbernstein2 as code owners August 23, 2024 11:39
tritone
tritone approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage changes are fine. @codyoss wanna go ahead and merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhshkh bhshkh bhshkh approved these changes

@tritone tritone tritone approved these changes

@igorbernstein2 igorbernstein2 Awaiting requested review from igorbernstein2 igorbernstein2 is a code owner

@gkevinzheng gkevinzheng Awaiting requested review from gkevinzheng gkevinzheng is a code owner automatically assigned from googleapis/api-logging

@mrfaizal mrfaizal Awaiting requested review from mrfaizal mrfaizal is a code owner automatically assigned from googleapis/api-bigquery

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf: fmt.Errorf used instead of errors.New
3 participants
@egonelbre @tritone @bhshkh