Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): add unknown host to retriable errors #10619

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix(storage): add unknown host to retriable errors #10619

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70d3486
fix(storage): add unknown host to retriable errors
BrennaEpp Jul 31, 2024
bed23bf
use DNSError.Temporary
BrennaEpp Sep 23, 2024
f4da717
Merge branch 'main' into unknownhost
BrennaEpp Sep 23, 2024
8e3960a
Merge branch 'main' into unknownhost
BrennaEpp Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions storage/invoke.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ func ShouldRetry(err error) bool {
return true
}
}
case *net.DNSError:
if strings.Contains(e.Error(), "no such host") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be retriable https://pkg.go.dev/net#DNSError.Temporary; is there more context?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I can't remember why I didn't use this to start off with, but it makes more sense. Updated. Context is just that we want to ensure to retry DNS errors as well.

return true
}
case interface{ Temporary() bool }:
if e.Temporary() {
return true
Expand Down
Loading